[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165421#comment-13165421 ] 

Phabricator commented on HBASE-4969:
------------------------------------

stack has accepted the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".

  +1

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/HRegionInfo.java:740 Your fix looks right Prakash.

REVISION DETAIL
  https://reviews.facebook.net/D669

                
> tautology in HRegionInfo.readFields
> -----------------------------------
>
>                 Key: HBASE-4969
>                 URL: https://issues.apache.org/jira/browse/HBASE-4969
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Prakash Khemani
>            Assignee: Prakash Khemani
>         Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
>     } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
>     } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira