You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/18 18:38:14 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #5989: GEODE-8905: Introduce JarDeploymentService

DonalEvans commented on a change in pull request #5989:
URL: https://github.com/apache/geode/pull/5989#discussion_r578655302



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
##########
@@ -94,26 +92,16 @@ public void deployJarsReceivedFromClusterConfiguration(ConfigurationResponse res
             .flatMap(Set::stream)
             .collect(Collectors.toList());
 
-    if (jarFileNames != null && !jarFileNames.isEmpty()) {
+    if (!jarFileNames.isEmpty()) {
       logger.info("Got response with jars: {}", jarFileNames.stream().collect(joining(",")));

Review comment:
       This line can be replaced with `logger.info("Got response with jars: {}", String.join(",", jarFileNames));`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org