[GitHub] [druid] gianm commented on pull request #13206: SQL: Use timestamp_floor when granularity is not safe.

[GitBox <gi...@apache.org>]

gianm commented on PR #13206:
URL: https://github.com/apache/druid/pull/13206#issuecomment-1274050908

   There are two better solutions that I didn't do in this patch due to them being more complex:
   
   1) Improving the query execution logic so the `granularity` feature doesn't incur overhead for buckets that aren't needed. The idea here would be to let the cursor drive the bucketing, rather than letting the bucketing drive the cursor.
   2) Improving the performance of `timestamp_floor` so `granularity` is not needed. The SQL planner would always generate GroupBy with `timestamp_floor`: no timeseries queries, and no GroupBy-with-granularity.
   
   Personally I think path (2) is the best one for the future. That being said, there is a need to have these queries execute properly today, hence the present patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org