[GitHub] [spark] grundprinzip commented on a diff in pull request #39753: [SPARK-42125][CONNECT][PYTHON] Pandas UDF in Spark Connect

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #39753:
URL: https://github.com/apache/spark/pull/39753#discussion_r1088698727


##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -297,7 +297,7 @@ message Expression {
   }
 }
 
-message ScalarInlineUserDefinedFunction {
+message CommonUserDefinedFunction {

Review Comment:
   So I'm not sure I 100% agree with the renaming, and would like to invite a bit more feedback from @HyukjinKwon @hvanhovell and others.
   
   The reason why we picked initially `ScalarInlineUserDefinedFunction` was because it represents a scalar function with an inlined defined function body.
   
   If we rename this to `CommonUserDefinedFunction` it's not 100% clear if the message is a scalar function or an aggregate function, does it contain the function body or not.
   
   Personally, if we really have to get rid of the scalar piece, I would prefer `CommonInlineUserDefinedFunction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org