You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ascheman (via GitHub)" <gi...@apache.org> on 2025/03/11 07:55:24 UTC
[PR] Build Site and fix 1288 [maven-mvnd]
ascheman opened a new pull request, #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289
Besides a fix for #1288 the change also contains
* a respective CI build (`mvn ... site`) to detect such problems early in the future
* a simplification for GH CI triggers (build on each push, not only master and PRs)
The latter leads to CI builds for each development change (which is a major purpose of an automatic build and helps in particular for forks/new contributors who cannot issue a automatic build by creating a PR). Having said that, the respective commit could be dropped if there is a good reason not to follow this practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289#discussion_r1994190300
##########
.github/workflows/early-access.yaml:
##########
@@ -47,7 +44,7 @@ jobs:
distribution: 'temurin'
- name: 'Run default (non-native) build'
- run: ./mvnw verify -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
+ run: ./mvnw verify site -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
Review Comment:
I'd not interleave site into this one... @gnodet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on code in PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289#discussion_r2002545607
##########
.github/workflows/early-access.yaml:
##########
@@ -47,7 +44,7 @@ jobs:
distribution: 'temurin'
- name: 'Run default (non-native) build'
- run: ./mvnw verify -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
+ run: ./mvnw verify site -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
Review Comment:
Moved it to another Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "ascheman (via GitHub)" <gi...@apache.org>.
ascheman commented on PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289#issuecomment-2785579153
Would anyone mind to merge this, @gnodet or @cstamas ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289#discussion_r1994225591
##########
.github/workflows/early-access.yaml:
##########
@@ -47,7 +44,7 @@ jobs:
distribution: 'temurin'
- name: 'Run default (non-native) build'
- run: ./mvnw verify -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
+ run: ./mvnw verify site -Dmrm=false -V -B -ntp -e -s .mvn/release-settings.xml
Review Comment:
Yes, maybe another job would be better specifically for the site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build Site and fix 1288 [maven-mvnd]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1289:
URL: https://github.com/apache/maven-mvnd/pull/1289#discussion_r1994189907
##########
pom.xml:
##########
@@ -95,6 +95,8 @@
<version.plexus-xml>4.0.4</version.plexus-xml>
<jakarta.inject.version>2.0.1</jakarta.inject.version>
+ <version.maven-fluido-skin>2.0.1</version.maven-fluido-skin>
Review Comment:
Isn't 2.1.0 just released? Why 2.0.1 exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org