[GitHub] [pulsar] merlimat commented on issue #4018: Support multi-host for pulsar-admin

[GitBox <gi...@apache.org>]

merlimat commented on issue #4018: Support multi-host for pulsar-admin
URL: https://github.com/apache/pulsar/pull/4018#issuecomment-492051274
 
 
   @zymap @sijie @jiazhai  
   
   I think there are a couple of problems with this PR. 
   
    1. The unit tests are now broken (100% of the times) in master and reverting this change is "fixing" the issue: 
   `Method org.apache.pulsar.stats.client.PulsarBrokerStatsClientTest.testServiceException() didn't finish within the time-out 300000`
   
    2. This change only applies the multi-host logic for the sync client request ( at https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java#L120) but it does not do that for the async requests path: https://github.com/apache/pulsar/blob/master/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java#L197
    I think that doing the logic in the async case would be better, since it would apply to both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services