You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/03/03 18:06:15 UTC
Review Request 44343: Used single space in license check error
message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Used single space in license check error message.
Diffs
-----
support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730
Diff: https://reviews.apache.org/r/44343/diff/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 44343: Used single space in license check error
message.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/#review121992
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44343]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 3, 2016, 5:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44343/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5:06 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used single space in license check error message.
>
>
> Diffs
> -----
>
> support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730
>
> Diff: https://reviews.apache.org/r/44343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44343: Used single space in license check error
message.
Posted by Till Toenshoff <to...@me.com>.
> On March 3, 2016, 8:12 p.m., Till Toenshoff wrote:
> > support/mesos-style.py, line 90
> > <https://reviews.apache.org/r/44343/diff/1/?file=1279526#file1279526line90>
> >
> > Are the two leading spaces intentional?
>
> Benjamin Bannier wrote:
> Yes, this is intentional to be consistent with `cpplint`'s output format, see https://github.com/apache/mesos/blob/master/support/cpplint.py#L1012 (we use the default output format which is `emacs`).
Thanks for clearifying - committing this now.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/#review121927
-----------------------------------------------------------
On March 3, 2016, 5:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44343/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5:06 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used single space in license check error message.
>
>
> Diffs
> -----
>
> support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730
>
> Diff: https://reviews.apache.org/r/44343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44343: Used single space in license check error
message.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 3, 2016, 9:12 p.m., Till Toenshoff wrote:
> > support/mesos-style.py, line 90
> > <https://reviews.apache.org/r/44343/diff/1/?file=1279526#file1279526line90>
> >
> > Are the two leading spaces intentional?
Yes, this is intentional to be consistent with `cpplint`'s output format, see https://github.com/apache/mesos/blob/master/support/cpplint.py#L1012 (we use the default output format which is `emacs`).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/#review121927
-----------------------------------------------------------
On March 3, 2016, 6:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44343/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 6:06 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used single space in license check error message.
>
>
> Diffs
> -----
>
> support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730
>
> Diff: https://reviews.apache.org/r/44343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 44343: Used single space in license check error
message.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44343/#review121927
-----------------------------------------------------------
support/mesos-style.py (line 90)
<https://reviews.apache.org/r/44343/#comment183781>
Are the two leading spaces intentional?
- Till Toenshoff
On March 3, 2016, 5:06 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44343/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 5:06 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used single space in license check error message.
>
>
> Diffs
> -----
>
> support/mesos-style.py 815d88c1935ae8248cd76a73d3dd613312b1d730
>
> Diff: https://reviews.apache.org/r/44343/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>