You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wzhfy <gi...@git.apache.org> on 2017/10/30 16:20:15 UTC
[GitHub] spark pull request #19610: [SPARK-22400] [SQL] rename some APIs and classes ...
GitHub user wzhfy opened a pull request:
https://github.com/apache/spark/pull/19610
[SPARK-22400] [SQL] rename some APIs and classes to make their meaning clearer
## What changes were proposed in this pull request?
Both `ReadSupport` and `ReadTask` have a method called `createReader`, but they create different things. This could cause some confusion for data source developers. The same problem exists between `WriteSupport` and `DataWriterFactory`, both of which have a method called `createWriter`. This PR renames the method of `ReadTask`/`DataWriterFactory` to `createDataReader`/`createDataWriter`.
Besides, the name of `RowToInternalRowDataWriterFactory` is not correct, because it actually converts `InternalRow`s to `Row`s. It should be renamed `InternalRowDataWriterFactory`.
## How was this patch tested?
Only renaming, should be covered by existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wzhfy/spark rename
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19610
----
commit 12a37030fe477cac2d165cdfa99bfb4170dfbafc
Author: Zhenhua Wang <wz...@163.com>
Date: 2017-10-30T15:58:17Z
do some rename
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19610
Thanks! Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19610
Is the idea that this is unreleased and can be renamed?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by wzhfy <gi...@git.apache.org>.
Github user wzhfy commented on the issue:
https://github.com/apache/spark/pull/19610
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19610
**[Test build #83216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83216/testReport)** for PR 19610 at commit [`12a3703`](https://github.com/apache/spark/commit/12a37030fe477cac2d165cdfa99bfb4170dfbafc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class InternalRowDataWriterFactory(`
* `class InternalRowDataWriter(rowWriter: DataWriter[Row], encoder: ExpressionEncoder[Row])`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19610
yea, and we can't change it after release.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19610
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19610: [SPARK-22400] [SQL] rename some APIs and classes ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19610
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19610
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83216/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19610
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19610: [SPARK-22400] [SQL] rename some APIs and classes to make...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19610
**[Test build #83216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83216/testReport)** for PR 19610 at commit [`12a3703`](https://github.com/apache/spark/commit/12a37030fe477cac2d165cdfa99bfb4170dfbafc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org