You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Tim McCune <tm...@fusura.com> on 2002/03/02 02:05:29 UTC

[PATCH] JUnitTask does not handle errors correctly

If haltOnError is set to false, the JUnit task does not throw any
exception at the end if there are any failures.  This patch makes it
wait until the end (i.e. it doesn't halt) and then throw a
BuildException if there were failures/errors.





Re: [PATCH] JUnitTask does not handle errors correctly

Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Tim McCune" <tm...@fusura.com>
To: <an...@jakarta.apache.org>
Sent: Friday, March 01, 2002 5:05 PM
Subject: [PATCH] JUnitTask does not handle errors correctly


> If haltOnError is set to false, the JUnit task does not throw any
> exception at the end if there are any failures.  This patch makes it
> wait until the end (i.e. it doesn't halt) and then throw a
> BuildException if there were failures/errors.

The usual approach is to set the failureProperty attribute to a property, go
through junit report to build a spiffy report of all the bugs then <fail> if
the failure the property.

your change would break this process.

Is there a reason why the standard practice doesnt work for you?

-steve


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>