[ofbiz-framework] 02/02: Improved: Refactor methods signature to reduce the number of params they use (OFBIZ-12335)

[jl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 3dc7731689122d1bdacf72a6f0f6a7cbf3b00376
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Sun Oct 10 11:49:38 2021 +0200

    Improved: Refactor methods signature to reduce the number of params they use (OFBIZ-12335)
    
    We currently have 115 checkstyle errors, most are related to methods using a too
    high number of params.
    
    Obviously nobody have currently time to work on this issue.
    
    This commit increases the max ParameterNumber to 26 to hide all current related
    errors. This reduces checkstyle errors to 54. It also allows to easier focus on
    other errors.
    It still possible to works on OFBIZ-12335 by temporary reverting this commit or
    replacing max ParameterNumber by the number wanted (was 10, is 7 by default)
---
 config/checkstyle/checkstyle.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 9bb4278..dbfa21a 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -74,7 +74,7 @@ under the License.
             <property name="countEmpty" value="false"/>
         </module>
         <module name="ParameterNumber">
-            <property name="max" value="10"/>
+            <property name="max" value="26"/>
             <property name="tokens" value="METHOD_DEF"/>
             <property name="ignoreOverriddenMethods" value="true"/>
         </module>