You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by eo...@apache.org on 2019/05/01 08:22:08 UTC

[maven-checkstyle-plugin] 02/02: [MCHECKSTYLE-353] - Don't resolve any dependencies

This is an automated email from the ASF dual-hosted git repository.

eolivelli pushed a commit to branch MCHECKSTYLE-353
in repository https://gitbox.apache.org/repos/asf/maven-checkstyle-plugin.git

commit 6abad1cb750244899c6e3b45a7a8bb49fba954db
Author: Zoran Regvart <zr...@apache.org>
AuthorDate: Mon May 7 15:33:07 2018 +0200

    [MCHECKSTYLE-353] - Don't resolve any dependencies
    
    Not sure why resolving dependencies is needed for running Checkstyle, it
    does slow down the build considerably. For Apache Camel this makes a
    ten fold difference from ~20mins to ~2mins for running
    `mvn checkstyle:check`.
    
    Seems this was introduced with MCHECKSTYLE-163 but subsequently
    integration test was removed in MCHECKSTYLE-272 (#42).
---
 .../apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java b/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
index b9b8e0e..9131b52 100644
--- a/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
+++ b/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
@@ -73,7 +73,7 @@ import com.puppycrawl.tools.checkstyle.api.CheckstyleException;
  * @author <a href="mailto:joakim@erdfelt.net">Joakim Erdfelt</a>
  * @version $Id$
  */
-@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST,
+@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.NONE,
        threadSafe = true )
 public class CheckstyleViolationCheckMojo
     extends AbstractMojo