You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Steven Jardine (Created) (JIRA)" <ji...@apache.org> on 2011/10/04 02:31:34 UTC
[jira] [Created] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
_openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
-------------------------------------------------------------------------------------------------------------
Key: NET-425
URL: https://issues.apache.org/jira/browse/NET-425
Project: Commons Net
Issue Type: Improvement
Components: FTP
Environment: All
Reporter: Steven Jardine
Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Sebb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119814#comment-13119814 ]
Sebb commented on NET-425:
--------------------------
Do you really require access to both the String and int versions of the methods?
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Environment: All
> Reporter: Steven Jardine
> Attachments: patch.txt
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Jardine updated NET-425:
-------------------------------
Attachment: retrievefile.patch
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt, retrievefile.patch
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-425.
----------------------
Resolution: Fixed
Thanks.
I modified the patch slightly; got rid of the private methods (only used once) and rearranged the methods to simplify the difference between versions.
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt, retrievefile.patch
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119836#comment-13119836 ]
Steven Jardine commented on NET-425:
------------------------------------
I only use the String methods. I guess you could leave the int methods private but I really don't see why private access is required for these methods.
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Environment: All
> Reporter: Steven Jardine
> Attachments: patch.txt
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Jardine updated NET-425:
-------------------------------
Attachment: (was: retrievefile.patch)
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt, retrievefile.patch
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Sebb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-425.
----------------------
Resolution: Fixed
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Environment: All
> Reporter: Steven Jardine
> Attachments: patch.txt
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Sebb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated NET-425:
---------------------
Affects Version/s: 3.0.1
Fix Version/s: 3.1
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Jardine updated NET-425:
-------------------------------
Attachment: retrievefile.patch
Fixed a bug with the patch.
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt, retrievefile.patch
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Jardine updated NET-425:
-------------------------------
Attachment: patch.txt
Please consider the attached patch for inclusion in the project.
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Environment: All
> Reporter: Steven Jardine
> Attachments: patch.txt
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (NET-425) _openDataConnection_, __storeFile, and
__storeFileStream should be protected and take String for FTP command.
Posted by "Steven Jardine (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Jardine reopened NET-425:
--------------------------------
While implementing my client I noticed a similiar problem with the receiveFile and receiveFileStream methods.
I have implemented __receiveFile, _receiveFile, __receiveFileStream, _receiveFileStream similiar to the __storeFile methods and modified the receiveFile and receiveFileStream methods to use these.
Please consider my patch for inclusion.
> _openDataConnection_, __storeFile, and __storeFileStream should be protected and take String for FTP command.
> -------------------------------------------------------------------------------------------------------------
>
> Key: NET-425
> URL: https://issues.apache.org/jira/browse/NET-425
> Project: Commons Net
> Issue Type: Improvement
> Components: FTP
> Affects Versions: 3.0.1
> Environment: All
> Reporter: Steven Jardine
> Fix For: 3.1
>
> Attachments: patch.txt, retrievefile.patch
>
>
> Currently __storeFile, __storeStream, and _openConnection_ are declared as private and only receive int commands. I am trying to extend the FTPClient class to implement specialized commands that utilize these methods. In order for this to work I need to have these methods declared as protected as well as adjust the parameters to allow for String commands.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira