You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/12/21 06:28:47 UTC
[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4059: [CARBONDATA-4092] Fix concurrent issues in delete segment API's and MV flow
ajantha-bhat commented on a change in pull request #4059:
URL: https://github.com/apache/carbondata/pull/4059#discussion_r546530685
##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java
##########
@@ -540,7 +540,7 @@ private void checkAndReloadSchemas(MVManager viewManager, boolean touchFile)
}
}
- private void touchMDTFile() throws IOException {
+ private synchronized void touchMDTFile() throws IOException {
Review comment:
In saveSchema() method of same file,
checkAndReloadSchemas(viewManager, true);
touchMDTFile();
line 432: after passing touch = true, again we are calling touchMDTFile, is itrequired?
##########
File path: core/src/main/java/org/apache/carbondata/core/view/MVProvider.java
##########
@@ -540,7 +540,7 @@ private void checkAndReloadSchemas(MVManager viewManager, boolean touchFile)
}
}
- private void touchMDTFile() throws IOException {
+ private synchronized void touchMDTFile() throws IOException {
Review comment:
@Indhumathi27 , @vikramahuja1001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org