You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/11/26 21:31:01 UTC

Review Request 71826: Updated StreamingHttpConnection to allow writing serialized records.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71826/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Greg Mann.


Bugs: MESOS-10026
    https://issues.apache.org/jira/browse/MESOS-10026


Repository: mesos


Description
-------

In order to more efficiently write the initial payload of the
master's operator API event stream, we will need to directly
serialize from the in-memory master state. To enable this, this
patch updates the streaming http connection to allow writing an
already serialized record.


Diffs
-----

  src/common/http.hpp b9ab561e11d52b776a283687b3a19aa1b7942522 


Diff: https://reviews.apache.org/r/71826/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 71826: Updated StreamingHttpConnection to allow writing serialized records.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71826/
-----------------------------------------------------------

(Updated Dec. 3, 2019, 5:27 a.m.)


Review request for mesos, Andrei Sekretenko and Greg Mann.


Changes
-------

* Adjusted for stateless encode function.


Bugs: MESOS-10026
    https://issues.apache.org/jira/browse/MESOS-10026


Repository: mesos


Description
-------

In order to more efficiently write the initial payload of the
master's operator API event stream, we will need to directly
serialize from the in-memory master state. To enable this, this
patch updates the streaming http connection to allow writing an
already serialized record.


Diffs (updated)
-----

  src/common/http.hpp b9ab561e11d52b776a283687b3a19aa1b7942522 


Diff: https://reviews.apache.org/r/71826/diff/2/

Changes: https://reviews.apache.org/r/71826/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Re: Review Request 71826: Updated StreamingHttpConnection to allow writing serialized records.

Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71826/#review218877
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Sekretenko


On Nov. 26, 2019, 9:31 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71826/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2019, 9:31 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Bugs: MESOS-10026
>     https://issues.apache.org/jira/browse/MESOS-10026
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to more efficiently write the initial payload of the
> master's operator API event stream, we will need to directly
> serialize from the in-memory master state. To enable this, this
> patch updates the streaming http connection to allow writing an
> already serialized record.
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp b9ab561e11d52b776a283687b3a19aa1b7942522 
> 
> 
> Diff: https://reviews.apache.org/r/71826/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>