You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/17 22:52:32 UTC

[GitHub] [kafka] ableegoldman commented on a change in pull request #8886: KAFKA-9891: fix corrupted StandbyTask state

ableegoldman commented on a change in pull request #8886:
URL: https://github.com/apache/kafka/pull/8886#discussion_r441876159



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##########
@@ -85,6 +85,21 @@ public void initializeMetadata() {}
     public boolean initializeStateStores() {
         log.trace("Initializing state stores");
         registerStateStores();
+
+        if (eosEnabled) {
+            final Set<TopicPartition> partitionsToReinitialize = new HashSet<>();
+            for (final TopicPartition partition : stateMgr.checkpointed().keySet()) {

Review comment:
       I think `checkpointed` is just misleadingly named -- it's really more like checkpoint_able_ offsets IIUC




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org