You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2021/10/25 08:07:36 UTC
[GitHub] [incubator-heron] windhamwong opened a new pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
windhamwong opened a new pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721
It gives an option for users to pick whether the apiserver service should be NodePort or ClusterIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-955091308
> > Is there a way to support asking for NodePort and letting k8s pick a random port, while also allowing for explicit port selection in the value.yml? Perhaps a property to enable/disable and another to set the value?
>
> good idea, maybe
>
> ```
> apiserver:
> NodePort:
> enabled: true
> port: <leave empty for random>
> ```
Yeah I think that could work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] windhamwong commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
windhamwong commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-963770479
The pushed code looks alright to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] windhamwong commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
windhamwong commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-950704834
Just updated to allow custom port number for NodePort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-961988798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] windhamwong commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
windhamwong commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-961675830
@nicknezis have a look :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] windhamwong commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
windhamwong commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-951627279
> Is there a way to support asking for NodePort and letting k8s pick a random port, while also allowing for explicit port selection in the value.yml? Perhaps a property to enable/disable and another to set the value?
good idea, maybe
```
apiserver:
NodePort:
enabled: true
port: <leave empty for random>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-961988798
Going to do some testing and maybe add the ability to use a random port number. Also just noticed that this feature branch is not made off of the main branch. We should rebase so that it can merge without any of the ARM branch's dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-962248948
@windhamwong I made the branch off of `master` branch.
I also realized that `helm` was stripping away the comments in the generated `values.yml` file. This issue was documented [here](https://github.com/helm/helm/issues/6951). It's fixed in Helm 3.1.0, so I updated the version of Helm that we are using.
I also did some minor refactoring of the values to start aggregating `apiserver`, `tracker` and `ui` sets of properties.
I also moved the `apiserver` Service up in `tools.yml` to group it with the other two `Service` definitions.
I also mirrored your logic to add `NodePort` support to the other two services.
I chose to keep the default behavior with k8s auto picking the NodePort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis merged pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis merged pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] windhamwong commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
windhamwong commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-961675830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nicknezis commented on pull request #3721: Helm: Adding option to switch the apiserver service between NodePort and ClusterIP
Posted by GitBox <gi...@apache.org>.
nicknezis commented on pull request #3721:
URL: https://github.com/apache/incubator-heron/pull/3721#issuecomment-950978520
Is there a way to support asking for NodePort and letting k8s pick a random port, while also allowing for explicit port selection in the value.yml? Perhaps a property to enable/disable and another to set the value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org