[GitHub] [hbase] comnetwork commented on pull request #4765: HBASE-27358 Avoid synchronization in AsyncFSWAL

[GitBox <gi...@apache.org>]

comnetwork commented on PR #4765:
URL: https://github.com/apache/hbase/pull/4765#issuecomment-1304504850

   @Apache9 , thank you for review and very sorry for later response, the approach is somewhat straightforward, `AsyncFSWAL` uses `consumeLock` to synchronize operations between `AsyncFSWAL.consumeExecutor` and `AsyncFSWAL.doReplaceWriter` or `AsyncFSWAL.doShutdown`, I think we could further use the event driven approach again to eliminate the `consumeLock`:
   For `AsyncFSWAL.doReplaceWriter` ,it could just publish the requesting roll WAL event to `AsyncFSWAL` and wait for the roll operation to complete. 
   For `AsyncFSWAL.consumeExecutor` ,it could detect the roll WAL event at its safe point (writer is broken or no `FSWALEntry` to write) and execute roll WAL event by itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org