[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #250: Update Spark runtime Jar contents

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #250: Update Spark runtime Jar contents
URL: https://github.com/apache/incubator-iceberg/pull/250#discussion_r300094252
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -218,8 +218,11 @@ project(':iceberg-core') {
   dependencies {
     compile project(':iceberg-api')
     compile project(':iceberg-common')
+    compile 'com.google.guava:guava:28.0-jre'
 
 Review comment:
   This dependency is already defined under subprojects with compileOnly scope. I think we should change the scope there to compile instead of re-adding the dependency here again since all subprojects require this dependency in a compile scope [and preferably shaded] 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org