You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/24 09:26:07 UTC

[GitHub] [zookeeper] symat commented on pull request #1546: ZOOKEEPER-4012: zookeeper-client-c: add an `install` target to CMakeLists

symat commented on pull request #1546:
URL: https://github.com/apache/zookeeper/pull/1546#issuecomment-732769920


   Hello! Thanks for the initiative / contribution @Hugmeir !  In general I like the idea, and I also think the questions raised by @ztzg are important. 
   
   Sorry, I can't go much deeper to this PR right now, also I'm not really an expert in cmake or in make in general. But I'll follow this PR and I'm happy to test it later.
   
   >One thing you have to be aware of, is that this build mechanism was initially contributed for "easier" Windows support; as far as I can tell, everybody still uses Autotools on POSIX-ish platforms.
   
   this is true, and AFAIK cmake is the only way now how to build the C client on windows, so it is important that whatever we change here we should test it on windows too (I can help with that). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org