You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "TamasNeumer (via GitHub)" <gi...@apache.org> on 2023/07/31 04:32:32 UTC
[GitHub] [nifi] TamasNeumer opened a new pull request, #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
TamasNeumer opened a new pull request, #7545:
URL: https://github.com/apache/nifi/pull/7545
…n resultSetScale was zero.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11860](https://issues.apache.org/jira/browse/NIFI-11860)
# Tracking
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] TamasNeumer commented on pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
Posted by "TamasNeumer (via GitHub)" <gi...@apache.org>.
TamasNeumer commented on PR #7545:
URL: https://github.com/apache/nifi/pull/7545#issuecomment-1661814686
When creating the `ResultSetRecordSet` object, the default `defaultScale` was `0`.
Previously if the `resultSetScale` was `0` then the default (`0`) `defaultScale` was applied.
Therefore I created a new test (`testCreateSchemaWhenScaleIsNonDefault`), where the scale is set. With the old code (`decimalScale = resultSetScale > 0 ? resultSetScale : defaultScale;`) the test fails, whereas with the fix (`decimalScale = resultSetScale >= 0 ? resultSetScale : defaultScale;`) it passes.
I hope this is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 closed pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
URL: https://github.com/apache/nifi/pull/7545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] TamasNeumer commented on pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
Posted by "TamasNeumer (via GitHub)" <gi...@apache.org>.
TamasNeumer commented on PR #7545:
URL: https://github.com/apache/nifi/pull/7545#issuecomment-1661083943
Thanks, I will add the test tomorrow and let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7545:
URL: https://github.com/apache/nifi/pull/7545#issuecomment-1662531068
+1 LGTM, thanks for the fix! Merging to main and support/nifi-1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #7545: NIFI-11860 fixed bug in ResultSetRecordSet affecting decimalScale whe…
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on PR #7545:
URL: https://github.com/apache/nifi/pull/7545#issuecomment-1660449862
I agree with the change and the request for a unit test to illustrate this. I will merge once the unit test is in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org