[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1075: Remove _tablet_meta_pb in TabletMeta

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1075: Remove _tablet_meta_pb in TabletMeta
URL: https://github.com/apache/incubator-doris/pull/1075#discussion_r279273873
 
 

 ##########
 File path: be/src/olap/tablet_schema.cpp
 ##########
 @@ -67,6 +73,9 @@ OLAPStatus TabletColumn::to_schema_pb(ColumnPB* column) {
     column->set_type(FieldInfo::get_string_by_field_type(_type));
     column->set_is_key(_is_key);
     column->set_is_nullable(_is_nullable);
+    if (_has_default_value) {
 
 Review comment:
   duplicate with line 83

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org