You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2010/12/01 12:34:41 UTC
DO NOT REPLY [Bug 50391] New: [PATCH] Add support for different
flow-name of fo:region-body in FOP
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
Summary: [PATCH] Add support for different flow-name of
fo:region-body in FOP
Product: Fop
Version: 1.1dev
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: page-master/layout
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: peter.hancock@gmail.com
This patch is not an implementation of flow-maps. The intention is for
simple-page-masters that reference flows that are not defined in the
page-sequence should generate empty flows- that is pages with the content layed
out in the region-body.
This implementation is not inconsistent with section 6.4.1.5 of the XSL
recommendation (1.0 & 1.1)
example.fo (attached) will cause the trunk to throw due to unmapped flows,
however this patch will produce an even and odd alternatives of empty and 'main
flow' pages.
This patch also introduces 3 dependencies as part of the unit test coverage:
mockito-core-1.8.5.jar
hamcrest.core-1.1.0.jar
objenesis-1.0.0.jar
They are to be placed in lib/build.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #4 from Chris Bowditch <bo...@hotmail.com> 2012-01-10 14:54:18 UTC ---
Hi Peter,
Thanks for submitting this patch. I have reviewed it and found a couple of
issues. There were some minor conflicts due to the age of the patch that I
resolved. I also had to update the tests to Junit4. My question is around the
AllTests class added to the pagination package. 2 test were added to this
package:
PageSequenceMasterTestCase
RepeatablePageMasterAlternativesTestCase
but the AllTest class only references PageSequenceMasterTestCase. Is that
intentional or should it also reference the
RepeatablePageMasterAlternativesTestCase?
Thanks,
Chris
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
--- Comment #1 from Peter Hancock <pe...@gmail.com> 2010-12-01 06:35:35 EST ---
Created an attachment (id=26360)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26360)
Patch for enhancement
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
--- Comment #3 from Peter Hancock <pe...@gmail.com> 2010-12-01 06:47:34 EST ---
All dependencies can be obtained from http://mockito.org/.
mockito-1.8.5.zip has a directory called seperate-jars containing
mockito-core-1.8.5.jar
hamcrest.core-1.1.0.jar
objenesis-1.0.0.jar
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
Chris Bowditch <bo...@hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from Chris Bowditch <bo...@hotmail.com> 2012-01-10 16:17:22 UTC ---
Thanks Peter. I've committed you patch and unit tests in revision 1229622
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
--- Comment #2 from Peter Hancock <pe...@gmail.com> 2010-12-01 06:36:52 EST ---
Created an attachment (id=26361)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26361)
example .fo demonstrating patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
Peter Hancock <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #5 from Peter Hancock <pe...@gmail.com> 2012-01-10 15:24:10 UTC ---
Well spotted Chris, RepeatablePageMasterAlternativesTestCase should be run.
The AllTest class should contain something like
@SuiteClasses({ PageSequenceMasterTestCase.class,
RepeatablePageMasterAlternativesTestCase.class })
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50391] [PATCH] Add support for different flow-name
of fo:region-body in FOP
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50391
Peter Hancock <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.