[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4783: Allow custom tree builder for parquet::record::RowIter

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4783:
URL: https://github.com/apache/arrow-rs/pull/4783#discussion_r1318416102


##########
parquet/src/record/reader.rs:
##########
@@ -747,6 +747,12 @@ impl<'a> RowIter<'a> {
         }
     }
 
+    /// Sets tree builder for this row iter.
+    pub fn with_tree_builder(mut self, tree_builder: TreeBuilder) -> Self {

Review Comment:
   I'm not very familiar with the row APIs, but perhaps it might be more future-proof to just add a with_batch_size method? This would hedge us against any stateful additions to TreeBuilder



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org