[GitHub] geode pull request #483: GEODE-2853: Change of locator list request interval

[bschuchardt <gi...@git.apache.org>]

Github user bschuchardt commented on a diff in the pull request:

    https://github.com/apache/geode/pull/483#discussion_r114611067
  
    --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/LocatorTestBase.java ---
    @@ -289,6 +289,13 @@ public void run() throws Exception {
         }
       }
     
    +  protected void startBridgeClient(final String group, final String host, final int port,
    --- End diff --
    
    Since this method is setting system properties I don't think it is appropriate to have it in LocatorTestBase.  You should move it to AutoConnectionSourceDUnitTest and use the DistributedRestoreSystemProperties rule to ensure that the properties are cleaned up.  To do that, add this to AutoConnectionSourceDUnitTest:
    
      @Rule
      public DistributedRestoreSystemProperties restoreSystemProperties =
          new DistributedRestoreSystemProperties();



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---