[PR] Remove the JUnit 4 leftovers [maven-wagon]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #941:
URL: https://github.com/apache/maven-wagon/pull/941

   Forward-port of #939 and its follow-up from `wagon-3.x`, where this landed first.
   
   The developer guide described the JUnit 3 and 4 shape in four places: `wagon-provider-test`
   dragging in JUnit 3-style `PlexusTestCase`, `WagonTestCase extends PlexusTestCase`, `getWagon()`
   calling `lookup(Wagon.ROLE, getProtocol())`, and the TCK as a JUnit 4 suite wired with
   `@RunWith(Suite.class)`. None of that has been true since #936. The guide now also names
   `junit-platform-suite` as a dependency a provider has to add for `@Suite`; without it the suite
   class compiles but selects nothing.
   
   The four `junit:junit` exclusions no longer exclude anything, and the managed `junit:junit`
   version has no consumer left once the sample below is gone.
   
   `wagon-tcks/wagon-tck-http/sample-tck-consumer` goes: not a reactor module, nothing references
   it, pinned at `wagon-http-lightweight` 1.0-beta-6, and its `TestSuite` is still
   `@RunWith(Suite.class)`, so the one worked example of consuming the TCK shows the wiring the
   guide warns against.
   
   Two changes from the `wagon-3.x` commits do not apply here. `TestPrompter` and the `wagon-ssh`
   test `components.xml` exist only on that line, so their comment fixes have nothing to land on.
   
   Verified: per-module `<testcase>` counts are unchanged against `0962d3e6`.
   
   *This change was created with AI assistance.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove the JUnit 4 leftovers [maven-wagon]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz merged PR #941:
URL: https://github.com/apache/maven-wagon/pull/941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org