[jira] [Commented] (YARN-5697) Use CliParser to parse options in RMAdminCLI

["Tao Jie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559662#comment-15559662 ] 

Tao Jie commented on YARN-5697:
-------------------------------

When I was trying to parse command line in RMAdminCLI by CliParser, I found that existing acceptable command line logic is not so restrict.
eg:
{{yarn rmadmin -addToClusterNodeLabels -directlyAccessNodeLabelStore label1}} is acceptable, however when using CLIParser to parse this cmd line, *label1* would be parsed as argument of option *-directlyAccessNodeLabelStore* rather than *-addToClusterNodeLabels*. Actually it makes more sense.
Same situation in cmd {{-removeFromClusterNodeLabels <label1,label2,label3> (label splitted by ",")}} and {{-replaceLabelsOnNode \[-failOnUnknownNodes\] <"node1\[:port\]=label1,label2 node2\[:port\]=label1,label2">}}
I am not sure if we should keep a loose logic to ensure compatibility(we should consider *label1* is arg of *-directlyAccessNodeLabelStore* or  *-addToClusterNodeLabels*, both are ok) or make the command line logic more accurate. 
[~Naganarasimha], [~sunilg], [~leftnoteasy], thoughts?


> Use CliParser to parse options in RMAdminCLI
> --------------------------------------------
>
>                 Key: YARN-5697
>                 URL: https://issues.apache.org/jira/browse/YARN-5697
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>             Fix For: 2.8.0
>
>
> As discussed in YARN-4855, it is better to use CliParser rather than args to parse command line options in RMAdminCli.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org