[jira] [Commented] (ZOOKEEPER-1055) check for duplicate ACLs in addACL() and create()

["Mahadev konar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055319#comment-13055319 ] 

Mahadev konar commented on ZOOKEEPER-1055:
------------------------------------------

eugene,
 The patch looks good.

One minor nit:

{code}
 if (authInfo.contains(id) == false) {
           authInfo.add(id);
 }
{code}
 
can be replaced by:

{code}
 if (!authInfo.contains(id)) {
           authInfo.add(id);
        }
{code}

I can make the minor change and check it in. Let me know.


> check for duplicate ACLs in addACL() and create()
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-1055
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1055
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.0
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch, ZOOKEEPER-1055.patch
>
>
> actual result:
> [zk: (CONNECTED) 0] create /test2 'test2' digest:test:test:cdrwa,digest:test:test:cdrwa
> Created /test2
> [zk: (CONNECTED) 1] getAcl /test2
> 'digest,'test:test
> : cdrwa
> 'digest,'test:test
> : cdrwa
> [zk: (CONNECTED) 2]
> but getAcl should only have a single entry.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira