[GitHub] [iceberg] nastra commented on a diff in pull request #6327: ORC: Fix error when projecting nested indentity partition column

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6327:
URL: https://github.com/apache/iceberg/pull/6327#discussion_r1040867729


##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -136,7 +136,16 @@ public static Types.StructType selectNot(Types.StructType struct, Set<Integer> f
   }
 
   public static Schema selectNot(Schema schema, Set<Integer> fieldIds) {
-    Set<Integer> projectedIds = getIdsInternal(schema.asStruct(), false);
+    return selectNot(schema, fieldIds, false);
+  }
+
+  public static Schema selectNotPreserveEmptyStructs(Schema schema, Set<Integer> fieldIds) {

Review Comment:
   maybe we should just have a single utility method for reading the schema without constants and without metadata fields rather than doing it in multiple places? Then we wouldn't need to expose `selectNotPreserveEmptyStructs`. wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org