You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/09 01:09:15 UTC

Review Request 65580: Improved logging for disk resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65580/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

For CSI disk resources, the root path is redundunt since it can be
derived from the source ID, so we print the root path only for non-CSI
disk resources.


Diffs
-----

  src/common/resources.cpp 262dcfb5306fd1824aa8620ccd4b7a14285a7855 
  src/v1/resources.cpp 06e310f43d1d570bdb4c44dac3640cc1357b54a5 


Diff: https://reviews.apache.org/r/65580/diff/1/


Testing
-------

make


Thanks,

Chun-Hung Hsiao

Re: Review Request 65580: Improved logging for disk resources.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65580/#review197143
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 9, 2018, 1:09 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65580/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2018, 1:09 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For CSI disk resources, the root path is redundunt since it can be
> derived from the source ID, so we print the root path only for non-CSI
> disk resources.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 262dcfb5306fd1824aa8620ccd4b7a14285a7855 
>   src/v1/resources.cpp 06e310f43d1d570bdb4c44dac3640cc1357b54a5 
> 
> 
> Diff: https://reviews.apache.org/r/65580/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>