[GitHub] [tika] kkrugler commented on a change in pull request #379: Fix unecessary close

[GitBox <gi...@apache.org>]

kkrugler commented on a change in pull request #379:
URL: https://github.com/apache/tika/pull/379#discussion_r521758824



##########
File path: tika-core/src/test/java/org/apache/tika/config/ParamTest.java
##########
@@ -61,8 +61,6 @@ public void testSaveAndLoad() throws Exception {
             ByteArrayOutputStream stream = new ByteArrayOutputStream();
             param.save(stream);
             ByteArrayInputStream inStream = new ByteArrayInputStream(stream.toByteArray());
-            stream.close();
-            inStream.close();

Review comment:
       The call to `inStream.close()` is confusing here, as it's used in the next line. You're right that a `close()` for either stream does nothing, but to avoid false positive warnings from tools that aren't so smart, I would just move these two calls to the end of the loop. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org