[GitHub] [iceberg] nastra commented on a diff in pull request #6411: Core: Don't produce partition summaries on unpartitioned table

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6411:
URL: https://github.com/apache/iceberg/pull/6411#discussion_r1045769408


##########
core/src/test/java/org/apache/iceberg/TestRowDelta.java:
##########
@@ -896,17 +896,14 @@ public void testAddDeleteFilesMultipleSpecs() {
     Map<String, String> summary = snapshot.summary();
 
     Assert.assertEquals(
-        "Should change 4 partitions", "4", summary.get(CHANGED_PARTITION_COUNT_PROP));
+        "Should change 3 partitions", "3", summary.get(CHANGED_PARTITION_COUNT_PROP));

Review Comment:
   the test does makes the table temporarily unpartitioned and this was wrongly counted here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org