[GitHub] [lucene] jpountz commented on a change in pull request #147: LUCENE-9827: Update backward codec in Lucene 9.0

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #147:
URL: https://github.com/apache/lucene/pull/147#discussion_r635443199



##########
File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/compressing/Lucene50CompressingStoredFieldsReader.java
##########
@@ -231,14 +238,45 @@ public Lucene50CompressingStoredFieldsReader(
       this.maxPointer = maxPointer;
       this.indexReader = indexReader;
 
-      if (version >= VERSION_META) {
+      if (version >= VERSION_NUM_CHUNKS) {
+        numChunks = metaIn.readVLong();
         numDirtyChunks = metaIn.readVLong();
         numDirtyDocs = metaIn.readVLong();

Review comment:
       since we won't do bulk merges anyway, maybe we could do like in the `else` block and just consume `metaIn` without setting `numXXX`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org