You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/04/04 00:07:00 UTC
[jira] [Commented] (KAFKA-9820)
validateMessagesAndAssignOffsetsCompressed allocates batch iterator which
is not used
[ https://issues.apache.org/jira/browse/KAFKA-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074978#comment-17074978 ]
ASF GitHub Bot commented on KAFKA-9820:
---------------------------------------
lbradstreet commented on pull request #8422: KAFKA-9820: validateMessagesAndAssignOffsetsCompressed allocates batc…
URL: https://github.com/apache/kafka/pull/8422
…h iterator which is not used
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> validateMessagesAndAssignOffsetsCompressed allocates batch iterator which is not used
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-9820
> URL: https://issues.apache.org/jira/browse/KAFKA-9820
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Lucas Bradstreet
> Priority: Major
>
> KAFKA-8106 added a new skip key/value iterator that reduces allocations [https://github.com/apache/kafka/commit/3e9d1c1411c5268de382f9dfcc95bdf66d0063a0].
> Unfortunately in LogValidator it creates that iterator but it never uses it, and this is quite expensive in terms of allocations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)