You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2019/12/12 23:47:34 UTC

[royale-asjs] 33/42: jewel-datagrid: remove change propagator since is not needed anymore

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit a7315196900047458daab5366867a340ed3a1781
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sat Dec 7 12:19:22 2019 +0100

    jewel-datagrid: remove change propagator since is not needed anymore
---
 .../projects/Jewel/src/main/resources/defaults.css |  1 -
 .../projects/Jewel/src/main/royale/JewelClasses.as |  1 -
 .../royale/org/apache/royale/jewel/DataGrid.as     |  9 ---
 .../datagrid/DataGridColumnChangePropagator.as     | 87 ----------------------
 .../Jewel/src/main/sass/components/_datagrid.sass  |  1 -
 5 files changed, 99 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css b/frameworks/projects/Jewel/src/main/resources/defaults.css
index 9dd08f1..9cd6e14 100644
--- a/frameworks/projects/Jewel/src/main/resources/defaults.css
+++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
@@ -512,7 +512,6 @@ j|ComboBoxPopUp {
 }
 
 j|DataGrid {
-  IChangePropagator: ClassReference("org.apache.royale.jewel.supportClasses.datagrid.DataGridColumnChangePropagator");
   IDataGridPresentationModel: ClassReference("org.apache.royale.jewel.beads.models.DataGridPresentationModel");
   IBeadView: ClassReference("org.apache.royale.jewel.beads.views.DataGridView");
   IBeadModel: ClassReference("org.apache.royale.html.beads.models.DataGridCollectionViewModel");
diff --git a/frameworks/projects/Jewel/src/main/royale/JewelClasses.as b/frameworks/projects/Jewel/src/main/royale/JewelClasses.as
index aa2f480..cb3102a 100644
--- a/frameworks/projects/Jewel/src/main/royale/JewelClasses.as
+++ b/frameworks/projects/Jewel/src/main/royale/JewelClasses.as
@@ -116,7 +116,6 @@ package
         
         import org.apache.royale.jewel.beads.views.DataGridView; DataGridView;
         import org.apache.royale.jewel.supportClasses.datagrid.DataGridColumnList; DataGridColumnList;
-        import org.apache.royale.jewel.supportClasses.datagrid.DataGridColumnChangePropagator; DataGridColumnChangePropagator;
         import org.apache.royale.jewel.beads.layouts.DataGridLayout; DataGridLayout;
 
         import org.apache.royale.jewel.supportClasses.util.positionInsideBoundingClientRect; positionInsideBoundingClientRect;
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/DataGrid.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/DataGrid.as
index 6df6f83..d975d56 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/DataGrid.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/DataGrid.as
@@ -19,12 +19,9 @@
 package org.apache.royale.jewel
 {
 	import org.apache.royale.core.IBead;
-	import org.apache.royale.core.IChangePropagator;
 	import org.apache.royale.core.IDataGridModel;
 	import org.apache.royale.core.IDataGridPresentationModel;
 	import org.apache.royale.core.ValuesManager;
-	import org.apache.royale.events.Event;
-	import org.apache.royale.utils.loadBeadFromValuesManager;
 	import org.apache.royale.jewel.supportClasses.datagrid.IDataGrid;
 	
 	[Event(name="change", type="org.apache.royale.events.Event")]
@@ -180,12 +177,6 @@ package org.apache.royale.jewel
 		{
 			(presentationModel as IDataGridPresentationModel).rowHeight = value;
 		}
-		
-		override public function addedToParent():void
-		{
-			loadBeadFromValuesManager(IChangePropagator, "iChangePropagator", this);
-			super.addedToParent();
-		}
 
 		private var _emphasis:String;
         /**
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnChangePropagator.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnChangePropagator.as
deleted file mode 100644
index 8ed6bcc..0000000
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/supportClasses/datagrid/DataGridColumnChangePropagator.as
+++ /dev/null
@@ -1,87 +0,0 @@
-
-////////////////////////////////////////////////////////////////////////////////
-//
-//  Licensed to the Apache Software Foundation (ASF) under one or more
-//  contributor license agreements.  See the NOTICE file distributed with
-//  this work for additional information regarding copyright ownership.
-//  The ASF licenses this file to You under the Apache License, Version 2.0
-//  (the "License"); you may not use this file except in compliance with
-//  the License.  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-//
-////////////////////////////////////////////////////////////////////////////////
-package org.apache.royale.jewel.supportClasses.datagrid
-{
-	import org.apache.royale.core.IBeadModel;
-	import org.apache.royale.core.IChangePropagator;
-	import org.apache.royale.core.IDataGridModel;
-	import org.apache.royale.core.ISelectionModel;
-	import org.apache.royale.core.IStrand;
-	import org.apache.royale.events.Event;
-	import org.apache.royale.events.IEventDispatcher;
-	import org.apache.royale.html.beads.IDataGridView;
-
-	/**
-	 *  The DataGridColumnChangePropagator picks up the dataProviderChanged event
-	 *  and lets the data grid columns know about it.
-	 *
-	 *  @viewbead
-	 *  @langversion 3.0
-	 *  @playerversion Flash 10.2
-	 *  @playerversion AIR 2.6
-	 *  @productversion Royale 0.9.7
-	 */
-	public class DataGridColumnChangePropagator implements IChangePropagator
-	{
-		public function DataGridColumnChangePropagator()
-		{
-		}
-		
-		private var _strand:IStrand;
-		/**
-		 * @royaleignorecoercion org.apache.royale.events.IEventDispatcher
-		 */
-		public function set strand(value:IStrand):void
-		{
-			_strand = value;
-			IEventDispatcher(_strand).addEventListener("beadsAdded", finishSetup);
-		}
-		
-		/**
-		 * @royaleignorecoercion org.apache.royale.events.IEventDispatcher
-		 */
-		protected function finishSetup(e:Event):void
-		{
-			var model:IEventDispatcher = _strand.getBeadByType(IBeadModel) as IEventDispatcher;
-			model.addEventListener('dataProviderChanged', handleDataProviderChanged);
-		}
-		
-		/**
-		 * @royaleignorecoercion org.apache.royale.core.IDataGridModel
-		 * @royaleignorecoercion org.apache.royale.core.ISelectionModel
-		 * @royaleignorecoercion org.apache.royale.html.beads.IDataGridView
-		 * @royaleignorecoercion org.apache.royale.html.supportClasses.DataGridColumnList
-		 */
-		protected function handleDataProviderChanged(e:Event):void
-		{
-			var dataGridView:IDataGridView = _strand.getBeadByType(IDataGridView) as IDataGridView;
-			var lists:Array = dataGridView.columnLists;
-			if (lists == null) return;
-			
-			var sharedModel:IDataGridModel = _strand.getBeadByType(IBeadModel) as IDataGridModel;
-			for (var i:int=0; i < lists.length; i++)
-			{
-				var list:DataGridColumnList = lists[i] as DataGridColumnList;
-				var listModel:ISelectionModel = list.getBeadByType(IBeadModel) as ISelectionModel;
-				listModel.dataProvider = sharedModel.dataProvider;
-			}
-		}
-	}
-}
diff --git a/frameworks/projects/Jewel/src/main/sass/components/_datagrid.sass b/frameworks/projects/Jewel/src/main/sass/components/_datagrid.sass
index 1a5bd0d..6af0bc2 100644
--- a/frameworks/projects/Jewel/src/main/sass/components/_datagrid.sass
+++ b/frameworks/projects/Jewel/src/main/sass/components/_datagrid.sass
@@ -50,7 +50,6 @@ $border-radius: .25rem
 
 
 j|DataGrid
-    IChangePropagator: ClassReference("org.apache.royale.jewel.supportClasses.datagrid.DataGridColumnChangePropagator")
     IDataGridPresentationModel: ClassReference("org.apache.royale.jewel.beads.models.DataGridPresentationModel")
     IBeadView: ClassReference("org.apache.royale.jewel.beads.views.DataGridView")
     IBeadModel: ClassReference("org.apache.royale.html.beads.models.DataGridCollectionViewModel")