You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/10/01 21:32:54 UTC

[GitHub] trafficserver pull request #1068: TS-4920: Consolidate accept socket options...

GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/1068

    TS-4920: Consolidate accept socket options.

    We have an object AcceptOptions that contains the options to apply
    to listening sockets, but in many places, the individual options
    are passed around. Consolidate this so that we pass a AcceptOptions
    to provide better guarantees that all listening sockets are created
    equal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1068.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1068
    
----
commit d60fa1e7ea8b35bc4592a33119b6d4874b5ad1d6
Author: James Peach <jp...@apache.org>
Date:   2016-10-01T00:12:20Z

    TS-4920: Consolidate accept socket options.
    
    We have an object AcceptOptions that contains the options to apply
    to listening sockets, but in many places, the individual options
    are passed around. Consolidate this so that we pass a AcceptOptions
    to provide better guarantees that all listening sockets are created
    equal.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1068: TS-4920: Consolidate accept socket options.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1068
  
    Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/807/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1068: TS-4920: Consolidate accept socket options...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:

    https://github.com/apache/trafficserver/pull/1068


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1068: TS-4920: Consolidate accept socket options.

Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:

    https://github.com/apache/trafficserver/pull/1068
  
    FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/912/ for details.
     



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1068: TS-4920: Consolidate accept socket options.

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:

    https://github.com/apache/trafficserver/pull/1068
  
    Ping @bryancall @amc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1068: TS-4920: Consolidate accept socket options.

Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:

    https://github.com/apache/trafficserver/pull/1068
  
    @jpeach Good job!
    
    And I have my own thoughts on AcceptOptions optimization, but it is quite basic and rough.
    
    1. class NetVCOptions as base class and defined in iocore/net/I_NetVConnection.h
    2. class AcceptOptions : public NetVCOptions and defined in iocore/net/I_NetAccept.h (moved it from P_NetAccept.h)
    3. class HttpSessionAcceptOptions : public AcceptOptions and defined in proxy/http/HttpSessionAccept.h
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---