You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2007/06/14 14:11:21 UTC

DO NOT REPLY [Bug 42659] New: - BeanShellIAssertion: include error from interpreter in message in GUI

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42659>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42659

           Summary: BeanShellIAssertion: include error from interpreter in
                    message in GUI
           Product: JMeter
           Version: 2.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: alf@i100.no


If I make a programming error in the script in the BeanShellAssertion, then I
see a message like this in the Assertion listener :
BeanShell Assertion : org.apache.jorphan.util.JMeterException: Error invoking
bsh method: eval

It would be nice if I could get the message from the beanshell interpreter, like
this :
BeanShell Assertion : org.apache.jorphan.util.JMeterException: Error invoking
bsh method: eval	Parse error at line 1, column 10.  Encountered: ==

I see in the BeanShellInterpreter code that the message from the interpreter is
included in the log file, but it would be nice to have in the GUI too.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42659] - BeanShellIAssertion: include error from interpreter in message in GUI

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42659>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42659


sebb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From sebb@apache.org  2007-06-14 08:43 -------
Good catch - I've applied the patch in SVN r547286.

I made a few more changes - I removed all the intermediate bshinvoke() calls 
so the public methods now call bshinvoke() directly.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 42659] - BeanShellIAssertion: include error from interpreter in message in GUI

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42659>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42659





------- Additional Comments From alf@i100.no  2007-06-14 05:16 -------
Created an attachment (id=20346)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=20346&action=view)
Suggested patch

Suggested patch to use the same message for the exception thrown as is sent to
the log file. The GUI will display the exception text, at least for beanshell
assertions. I haven't found any listener or anything that will show exceptions
from BeanShellPreProcessor or BeanShellPostProcessor.

The patch also restructures the code slightly, to avoid duplicating the code
for calling and handling errors from the beanshell interpreter.
Note that I have only tested this code minimally, but it looks correct to me.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org