You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/18 19:08:17 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
MaxGekk opened a new pull request #31586:
URL: https://github.com/apache/spark/pull/31586
### What changes were proposed in this pull request?
Explicitly highlight that the table rename command cannot move a table between databases.
### Why are the changes needed?
To inform users about actual behavior the table rename command.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
```sql
spark-sql> CREATE DATABASE db1;
spark-sql> CREATE DATABASE db2;
spark-sql> CREATE TABLE db1.tbl1 (c0 INT);
spark-sql> ALTER TABLE db1.tbl1 RENAME TO db2.tbl1;
Error in query: RENAME TABLE source and destination databases do not match: 'db1' != 'db2';
spark-sql> ALTER TABLE db1.tbl1 RENAME TO db1.tbl2;
spark-sql> SHOW TABLES IN db1 LIKE '*';
db1 tbl2 false
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781581677
**[Test build #135240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135240/testReport)** for PR 31586 at commit [`8eae0de`](https://github.com/apache/spark/commit/8eae0de53afd7a0c09cf333984b2be93a0ea46e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781600470
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135240/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781615979
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781600218
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781581677
**[Test build #135240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135240/testReport)** for PR 31586 at commit [`8eae0de`](https://github.com/apache/spark/commit/8eae0de53afd7a0c09cf333984b2be93a0ea46e0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781587596
**[Test build #135240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135240/testReport)** for PR 31586 at commit [`8eae0de`](https://github.com/apache/spark/commit/8eae0de53afd7a0c09cf333984b2be93a0ea46e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31586:
URL: https://github.com/apache/spark/pull/31586
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781631849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781631849
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781814151
@cloud-fan Do the changes make sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781600470
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135240/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781815508
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31586: [SPARK-34466][SQL][DOCS] Improve docs for `ALTER TABLE .. RENAME TO`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31586:
URL: https://github.com/apache/spark/pull/31586#issuecomment-781571223
https://github.com/apache/spark/pull/31575 adds tests for the case described in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org