You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/01/11 07:42:22 UTC
[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/4
Improved 'How to create a PR (contributors)' section saying a JIRA is\u2026
\u2026sue must be created on each PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq-site master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-site/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit ef18010fbbeb0ae4da973d3288c407971098e078
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-01-11T07:40:04Z
Improved 'How to create a PR (contributors)' section saying a JIRA issue must be created on each PR.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/4#discussion_r95922741
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -73,11 +73,15 @@ Push your branch to Github:
6. When you are satisfied and want to push it to Apache's remote repo proceed with Merging a PR
# How to create a PR (contributors)
-Create pull requests: [GitHub PR docs](https://help.github.com/articles/creating-a-pull-request/).
+Before you create a pull request, make sure
+1. A corresponding [JIRA](https://issues.apache.org/jira/browse/ROCKETMQ/) issue is created and has a clear problem description.
+2. You follow [Coding Guidelines](http://rocketmq.apache.org/docs/code-guidelines/).
--- End diff --
Maybe use a relative path is better, like:
`You follow \[Coding Guidelines\](/docs/code-guidelines/).`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site pull request #4: Improved 'How to create a PR (contr...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-site/pull/4#discussion_r95923375
--- Diff: _docs/06-best-practice-pull-request.md ---
@@ -73,11 +73,15 @@ Push your branch to Github:
6. When you are satisfied and want to push it to Apache's remote repo proceed with Merging a PR
# How to create a PR (contributors)
-Create pull requests: [GitHub PR docs](https://help.github.com/articles/creating-a-pull-request/).
+Before you create a pull request, make sure
+1. A corresponding [JIRA](https://issues.apache.org/jira/browse/ROCKETMQ/) issue is created and has a clear problem description.
+2. You follow [Coding Guidelines](http://rocketmq.apache.org/docs/code-guidelines/).
--- End diff --
@zhouxinyu yes, definitely. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #4: Improved 'How to create a PR (contributors...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/4
Sure, thanks @shroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #4: Improved 'How to create a PR (contributors...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/4
Can it be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---