You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/11/13 22:52:13 UTC
[jira] [Created] (HADOOP-9035) Generalize setup of LoginContext
Daryn Sharp created HADOOP-9035:
-----------------------------------
Summary: Generalize setup of LoginContext
Key: HADOOP-9035
URL: https://issues.apache.org/jira/browse/HADOOP-9035
Project: Hadoop Common
Issue Type: Sub-task
Components: security
Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497234#comment-13497234 ]
Hadoop QA commented on HADOOP-9035:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553506/HADOOP-9035.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegationTokenSupport
org.apache.hadoop.fs.viewfs.TestViewFsURIs
org.apache.hadoop.io.TestSequenceFileSerialization
org.apache.hadoop.security.TestUserFromEnv
org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
org.apache.hadoop.fs.shell.TestTextCommand
org.apache.hadoop.fs.TestTruncatedInputBug
org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.fs.TestFileContextResolveAfs
org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison
org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
org.apache.hadoop.fs.viewfs.TestViewFsTrash
org.apache.hadoop.fs.TestS3_LocalFileContextURI
org.apache.hadoop.fs.TestFsShellReturnCode
org.apache.hadoop.fs.viewfs.TestViewFsLocalFs
org.apache.hadoop.security.TestJNIGroupsMapping
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.TestHarFileSystem
org.apache.hadoop.fs.TestFilterFileSystem
org.apache.hadoop.ipc.TestIPCServerResponder
org.apache.hadoop.io.file.tfile.TestTFile
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsStreams
org.apache.hadoop.fs.TestFcLocalFsPermission
org.apache.hadoop.io.TestMapFile
org.apache.hadoop.fs.TestGetFileBlockLocations
org.apache.hadoop.io.file.tfile.TestTFileSplit
org.apache.hadoop.io.file.tfile.TestVLong
org.apache.hadoop.fs.viewfs.TestChRootedFs
org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
org.apache.hadoop.io.file.tfile.TestTFileUnsortedByteArrays
org.apache.hadoop.fs.TestFcLocalFsUtil
org.apache.hadoop.fs.TestLocalFileSystemPermission
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.fs.TestLocalFSFileContextSymlink
org.apache.hadoop.io.TestSequenceFile
org.apache.hadoop.fs.TestLocalFsFCStatistics
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.viewfs.TestViewFsConfig
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.ipc.TestRPCCompatibility
org.apache.hadoop.fs.TestPath
org.apache.hadoop.fs.TestLocalFSFileContextCreateMkdir
org.apache.hadoop.io.nativeio.TestNativeIO
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
org.apache.hadoop.fs.shell.TestCopy
org.apache.hadoop.fs.viewfs.TestChRootedFileSystem
org.apache.hadoop.fs.TestFileUtil
org.apache.hadoop.io.TestArrayFile
org.apache.hadoop.io.compress.TestCodec
org.apache.hadoop.fs.TestListFiles
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.io.TestSetFile
org.apache.hadoop.util.TestGenericOptionsParser
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
org.apache.hadoop.fs.TestLocalFileSystem
org.apache.hadoop.conf.TestConfiguration
org.apache.hadoop.ipc.TestMultipleProtocolServer
org.apache.hadoop.fs.TestChecksumFileSystem
org.apache.hadoop.ipc.TestProtoBufRpc
org.apache.hadoop.io.file.tfile.TestTFileComparators
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegation
org.apache.hadoop.io.file.tfile.TestTFileComparator2
org.apache.hadoop.io.file.tfile.TestTFileSeek
org.apache.hadoop.fs.TestLocal_S3FileContextURI
org.apache.hadoop.io.TestSequenceFileSync
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.fs.TestAvroFSInput
org.apache.hadoop.fs.TestTrash
org.apache.hadoop.io.TestSecureIOUtils
org.apache.hadoop.io.file.tfile.TestTFileStreams
org.apache.hadoop.fs.viewfs.TestViewfsFileStatus
org.apache.hadoop.fs.TestFileContextDeleteOnExit
org.apache.hadoop.io.TestBloomMapFile
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1744//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1744//console
This message is automatically generated.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Status: Patch Available (was: Open)
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497211#comment-13497211 ]
Hadoop QA commented on HADOOP-9035:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553505/HADOOP-9035.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.io.TestMapFile
org.apache.hadoop.fs.TestFcLocalFsPermission
org.apache.hadoop.fs.TestFilterFileSystem
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegation
org.apache.hadoop.fs.shell.TestCopy
org.apache.hadoop.fs.viewfs.TestViewFsTrash
org.apache.hadoop.io.file.tfile.TestTFileStreams
org.apache.hadoop.util.TestGenericOptionsParser
org.apache.hadoop.ipc.TestMultipleProtocolServer
org.apache.hadoop.fs.viewfs.TestViewFsURIs
org.apache.hadoop.fs.viewfs.TestViewfsFileStatus
org.apache.hadoop.security.TestUserFromEnv
org.apache.hadoop.fs.viewfs.TestChRootedFs
org.apache.hadoop.io.file.tfile.TestTFile
org.apache.hadoop.ipc.TestProtoBufRpc
org.apache.hadoop.fs.TestFsShellReturnCode
org.apache.hadoop.fs.TestFcLocalFsUtil
org.apache.hadoop.fs.TestLocalFsFCStatistics
org.apache.hadoop.io.file.tfile.TestTFileSplit
org.apache.hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs
org.apache.hadoop.fs.TestListFiles
org.apache.hadoop.fs.TestS3_LocalFileContextURI
org.apache.hadoop.fs.TestLocalFileSystem
org.apache.hadoop.fs.TestFsShellCopy
org.apache.hadoop.fs.viewfs.TestFcPermissionsLocalFs
org.apache.hadoop.fs.TestTruncatedInputBug
org.apache.hadoop.fs.TestTrash
org.apache.hadoop.io.nativeio.TestNativeIO
org.apache.hadoop.fs.shell.TestTextCommand
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsByteArrays
org.apache.hadoop.fs.TestFileContextResolveAfs
org.apache.hadoop.io.file.tfile.TestTFileSeqFileComparison
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsStreams
org.apache.hadoop.io.compress.TestCodec
org.apache.hadoop.fs.TestLocalFSFileContextCreateMkdir
org.apache.hadoop.fs.TestLocalFSFileContextMainOperations
org.apache.hadoop.io.file.tfile.TestTFileComparators
org.apache.hadoop.fs.shell.TestPathData
org.apache.hadoop.fs.viewfs.TestFcMainOperationsLocalFs
org.apache.hadoop.io.file.tfile.TestTFileNoneCodecsJClassComparatorByteArrays
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.io.TestSequenceFileSync
org.apache.hadoop.io.TestSecureIOUtils
org.apache.hadoop.io.TestSetFile
org.apache.hadoop.io.file.tfile.TestTFileSeek
org.apache.hadoop.fs.viewfs.TestViewFsConfig
org.apache.hadoop.fs.viewfs.TestFcCreateMkdirLocalFs
org.apache.hadoop.fs.TestLocal_S3FileContextURI
org.apache.hadoop.io.file.tfile.TestTFileByteArrays
org.apache.hadoop.fs.TestLocalFileSystemPermission
org.apache.hadoop.io.file.tfile.TestTFileUnsortedByteArrays
org.apache.hadoop.fs.TestFileUtil
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.fs.TestHarFileSystem
org.apache.hadoop.fs.TestPath
org.apache.hadoop.io.file.tfile.TestTFileComparator2
org.apache.hadoop.fs.TestLocalFSFileContextSymlink
org.apache.hadoop.fs.viewfs.TestViewFileSystemDelegationTokenSupport
org.apache.hadoop.fs.viewfs.TestViewFsLocalFs
org.apache.hadoop.io.TestArrayFile
org.apache.hadoop.conf.TestConfiguration
org.apache.hadoop.fs.TestChecksumFileSystem
org.apache.hadoop.io.TestSequenceFile
org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.TestLocalDirAllocator
org.apache.hadoop.security.TestJNIGroupsMapping
org.apache.hadoop.io.file.tfile.TestVLong
org.apache.hadoop.fs.TestAvroFSInput
org.apache.hadoop.io.TestBloomMapFile
org.apache.hadoop.io.TestSequenceFileSerialization
org.apache.hadoop.fs.TestGetFileBlockLocations
org.apache.hadoop.ipc.TestRPCCompatibility
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.io.file.tfile.TestTFileJClassComparatorByteArrays
org.apache.hadoop.ipc.TestIPCServerResponder
org.apache.hadoop.fs.TestFileContextDeleteOnExit
org.apache.hadoop.fs.viewfs.TestChRootedFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1742//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1742//console
This message is automatically generated.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Status: Open (was: Patch Available)
Bad patch.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498809#comment-13498809 ]
Hudson commented on HADOOP-9035:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1259 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1259/])
HADOOP-9035. Generalize setup of LoginContext (daryn via bobby) (Revision 1410018)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410018
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Attachment: HADOOP-9035.patch
Associate the login config name with the {{AuthenticationMethod}}, then remove switches and use the login config based on the configured auth method.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Attachment: HADOOP-9035.patch
Previous two failed tests are passing null for UGI. This is probably "wrong", but I don't know what elsewhere might be doing the same so I default an auth method for a null ugi to SIMPLE.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498793#comment-13498793 ]
Hudson commented on HADOOP-9035:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1228 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1228/])
HADOOP-9035. Generalize setup of LoginContext (daryn via bobby) (Revision 1410018)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410018
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498350#comment-13498350 ]
Hudson commented on HADOOP-9035:
--------------------------------
Integrated in Hadoop-trunk-Commit #3029 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3029/])
HADOOP-9035. Generalize setup of LoginContext (daryn via bobby) (Revision 1410018)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410018
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497192#comment-13497192 ]
Robert Joseph Evans commented on HADOOP-9035:
---------------------------------------------
The code looks good to me. About my only comment is that the new isSecurityEnabled(AuthenticationMethod) is kind of named badly. It is not really checking if security is enabled, it is checking to see if a given AuthenticationMethod is enabled or not. Could you rename it. I am +1 otherwise.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498342#comment-13498342 ]
Robert Joseph Evans commented on HADOOP-9035:
---------------------------------------------
The changes look good to me. All of the tests pass. +1
I'll check it in.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Attachment: HADOOP-9035.patch
Renamed the method as requested.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497448#comment-13497448 ]
Hadoop QA commented on HADOOP-9035:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553543/HADOOP-9035.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestIPCServerResponder
org.apache.hadoop.ipc.TestIPC
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1746//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1746//console
This message is automatically generated.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497598#comment-13497598 ]
Hadoop QA commented on HADOOP-9035:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12553579/HADOOP-9035.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1748//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1748//console
This message is automatically generated.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Status: Patch Available (was: Open)
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 2.0.0-alpha, 0.23.0, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Attachment: HADOOP-9035.patch
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498720#comment-13498720 ]
Hudson commented on HADOOP-9035:
--------------------------------
Integrated in Hadoop-Yarn-trunk #38 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/38/])
HADOOP-9035. Generalize setup of LoginContext (daryn via bobby) (Revision 1410018)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1410018
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-9035:
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
3.0.0
Status: Resolved (was: Patch Available)
Thanks Daryn,
I put this in trunk and branch-2
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-9035) Generalize setup of LoginContext
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-9035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-9035:
--------------------------------
Attachment: HADOOP-9035.patch
Arg. {{isSecurityEnabled}} is used to initialize the UGI's conf if it's not already, but the new method of instantiating a login context eschewed the call. I had to add an {{ensureInitialized}} to {{getLoginUser}} to compensate. Also used an accessor on the authentication method to get the login conf instead of direct field access.
> Generalize setup of LoginContext
> --------------------------------
>
> Key: HADOOP-9035
> URL: https://issues.apache.org/jira/browse/HADOOP-9035
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch, HADOOP-9035.patch
>
>
> The creation of the {{LoginContext}} in {{UserGroupInformation}} has specific cases for specific authentication types. This is inflexible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira