You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by tweise <gi...@git.apache.org> on 2015/10/14 08:34:56 UTC
[GitHub] incubator-apex-malhar pull request: REVIEW ONLY- MLHR-1869 Update ...
GitHub user tweise opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/58
REVIEW ONLY- MLHR-1869 Update Maven coordinates for ASF release.
@vrozov @davidyan74 First cut replacement. We need to discuss the .apa artifact distribution - they should not go into the ASF repo.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tweise/incubator-apex-malhar MLHR-1869
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit f1a876c94e466db876f07b225b4d7a2a72768ff2
Author: Thomas Weise <th...@datatorrent.com>
Date: 2015-10-14T06:30:13Z
MLHR-1869 Update Maven coordinates for ASF release.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: REVIEW ONLY- MLHR-1869 Update ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: REVIEW ONLY- MLHR-1869 Update ...
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/58#discussion_r42021171
--- Diff: contrib/pom.xml ---
@@ -601,9 +601,9 @@
<optional>true</optional>
</dependency>
<dependency>
- <groupId>com.datatorrent</groupId>
- <artifactId>dt-common</artifactId>
- <version>${dt.framework.version}</version>
--- End diff --
I think it's better to use apex.core.version instead of just apex.version since apex technically includes malhar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: REVIEW ONLY- MLHR-1869 Update ...
Posted by davidyan74 <gi...@git.apache.org>.
Github user davidyan74 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/58#discussion_r42020991
--- Diff: benchmark/pom.xml ---
@@ -519,13 +499,13 @@
</exclusions>
</dependency>
<dependency>
- <groupId>com.datatorrent</groupId>
- <artifactId>dt-engine</artifactId>
+ <groupId>org.apache.apex</groupId>
+ <artifactId>apex-engine</artifactId>
<version>3.0.0</version>
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>com.datatorrent</groupId>
+ <groupId>org.apache.apex</groupId>
<artifactId>dt-api</artifactId>
--- End diff --
apex-api?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---