You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "feiniaofeiafei (via GitHub)" <gi...@apache.org> on 2024/10/21 09:20:01 UTC
[PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
feiniaofeiafei opened a new pull request, #42199:
URL: https://github.com/apache/doris/pull/42199
this pr do 2 things:
1.support pull up predicates from aggregate min/max/avg. e.g.
```sql
select * from (select avg(c) c1 from test_like1 where c<=10 group by a ) t inner join test_like2 t2 on t.c1=t2.a;
```
c<=10 pull up from aggregate to avg(c)<=10, and then pull up from aggregate to t.c1<=10, and with equal join condition,can infer predicate t2.a<=10.
2. carry qualifier when pull up from projects, before this pr, c1<=10 pull up from project to c1<=10. after this pr, c1<=10 pull up from project to t.c1<=10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2636289162
<details>
<summary>TPC-H: <b>Total hot run time: 32422 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false
------ Round 1 ----------------------------------
q1 17596 5528 5405 5405
q2 2043 329 176 176
q3 10384 1330 728 728
q4 10220 967 532 532
q5 7699 2468 2167 2167
q6 196 164 132 132
q7 914 771 610 610
q8 9214 1332 1113 1113
q9 5476 4938 4895 4895
q10 6833 2325 1924 1924
q11 480 277 262 262
q12 342 364 223 223
q13 17767 3729 3134 3134
q14 239 217 210 210
q15 511 482 473 473
q16 653 616 597 597
q17 566 865 323 323
q18 6989 6487 6502 6487
q19 1234 936 539 539
q20 321 328 196 196
q21 2829 2210 1987 1987
q22 372 339 309 309
Total cold run time: 102878 ms
Total hot run time: 32422 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5507 5517 5449 5449
q2 238 324 233 233
q3 2207 2648 2332 2332
q4 1412 1829 1435 1435
q5 4342 4782 4680 4680
q6 168 159 122 122
q7 2095 1990 1856 1856
q8 2667 2806 2695 2695
q9 7228 7238 7180 7180
q10 2987 3266 2803 2803
q11 578 512 492 492
q12 640 758 619 619
q13 3576 4154 3325 3325
q14 292 309 269 269
q15 508 464 460 460
q16 645 687 640 640
q17 1203 1741 1239 1239
q18 7919 7430 7203 7203
q19 757 1175 1066 1066
q20 2025 2055 1935 1935
q21 5686 5187 5074 5074
q22 593 599 552 552
Total cold run time: 53273 ms
Total hot run time: 51659 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723302927
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963717032
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -379,4 +397,16 @@ private ImmutableSet<Expression> getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+ private Map<Slot, Expression> generateMap(List<NamedExpression> namedExpressions) {
+ Map<Slot, Expression> replaceMap = new LinkedHashMap<>(namedExpressions.size());
+ for (NamedExpression namedExpression : namedExpressions) {
+ if (namedExpression instanceof Alias) {
+ replaceMap.putIfAbsent(namedExpression.toSlot(), namedExpression.child(0));
+ } else if (namedExpression instanceof SlotReference) {
+ replaceMap.putIfAbsent((Slot) namedExpression, namedExpression);
Review Comment:
the qualifier may be different when there is a LogicalSubQueryAlias pushed to the LogicalProject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2803734715
<details>
<summary>TPC-H: <b>Total hot run time: 34236 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d131b92e19dabb9652588d7253de5ad3077f2b9b, data reload: false
------ Round 1 ----------------------------------
q1 26661 5135 5094 5094
q2 2090 299 186 186
q3 10381 1272 714 714
q4 10225 1029 565 565
q5 7506 2419 2368 2368
q6 193 163 133 133
q7 947 757 611 611
q8 9327 1395 1129 1129
q9 6987 5114 5119 5114
q10 6808 2346 1912 1912
q11 501 288 283 283
q12 353 357 220 220
q13 17767 3728 3073 3073
q14 225 222 211 211
q15 569 522 493 493
q16 632 621 573 573
q17 582 869 357 357
q18 7789 7288 7054 7054
q19 1210 958 552 552
q20 344 344 228 228
q21 4187 3359 2421 2421
q22 981 992 945 945
Total cold run time: 116265 ms
Total hot run time: 34236 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5112 5110 5100 5100
q2 246 344 232 232
q3 2255 2737 2307 2307
q4 1427 1912 1492 1492
q5 4522 4465 4374 4374
q6 211 177 124 124
q7 2112 1918 1757 1757
q8 2667 2543 2502 2502
q9 7171 7222 7057 7057
q10 2999 3215 2749 2749
q11 594 506 482 482
q12 708 792 617 617
q13 3539 3956 3211 3211
q14 275 300 275 275
q15 529 489 514 489
q16 659 674 638 638
q17 1159 1595 1370 1370
q18 7992 7738 7408 7408
q19 812 788 827 788
q20 1991 1958 1833 1833
q21 5173 4761 4698 4698
q22 1013 1010 960 960
Total cold run time: 53166 ms
Total hot run time: 50463 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723414288
<details>
<summary>ClickBench: <b>Total hot run time: 31.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.03
query3 0.23 0.07 0.06
query4 1.61 0.10 0.10
query5 0.55 0.54 0.55
query6 1.20 0.72 0.73
query7 0.04 0.02 0.02
query8 0.04 0.03 0.03
query9 0.60 0.53 0.52
query10 0.58 0.58 0.61
query11 0.16 0.10 0.11
query12 0.14 0.11 0.12
query13 0.61 0.59 0.60
query14 2.66 2.82 2.70
query15 0.93 0.86 0.87
query16 0.39 0.38 0.40
query17 1.03 0.99 1.02
query18 0.21 0.20 0.19
query19 1.90 1.89 2.02
query20 0.01 0.02 0.02
query21 15.37 0.88 0.53
query22 0.75 1.23 0.75
query23 14.78 1.40 0.62
query24 6.99 1.87 0.88
query25 0.48 0.40 0.07
query26 0.50 0.15 0.15
query27 0.05 0.05 0.06
query28 10.18 0.86 0.42
query29 12.56 3.98 3.36
query30 0.26 0.09 0.06
query31 2.81 0.58 0.39
query32 3.22 0.54 0.45
query33 3.00 3.02 3.02
query34 15.91 5.15 4.52
query35 4.58 4.54 4.55
query36 0.68 0.50 0.50
query37 0.10 0.07 0.06
query38 0.05 0.04 0.03
query39 0.04 0.03 0.02
query40 0.17 0.14 0.13
query41 0.10 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 105.64 s
Total hot run time: 31.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2921052422
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723366050
<details>
<summary>TPC-H: <b>Total hot run time: 32229 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false
------ Round 1 ----------------------------------
q1 17585 5277 5011 5011
q2 2033 299 162 162
q3 10495 1243 735 735
q4 10204 1000 523 523
q5 7513 2363 2316 2316
q6 185 161 133 133
q7 910 762 595 595
q8 9290 1262 1095 1095
q9 4905 4896 4576 4576
q10 6820 2315 1876 1876
q11 468 268 259 259
q12 344 344 217 217
q13 17771 3710 3083 3083
q14 228 228 211 211
q15 532 488 496 488
q16 623 618 557 557
q17 574 814 370 370
q18 6864 6445 6344 6344
q19 1224 935 543 543
q20 320 325 197 197
q21 2854 2146 1917 1917
q22 1037 1030 1021 1021
Total cold run time: 102779 ms
Total hot run time: 32229 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5165 5103 5132 5103
q2 241 323 232 232
q3 2208 2680 2330 2330
q4 1468 1865 1430 1430
q5 4308 4188 4232 4188
q6 213 166 125 125
q7 1865 1930 1857 1857
q8 2652 2680 2577 2577
q9 7357 7340 7253 7253
q10 3044 3271 2827 2827
q11 583 514 493 493
q12 705 804 620 620
q13 3494 3960 3301 3301
q14 278 308 279 279
q15 565 529 495 495
q16 672 679 645 645
q17 1133 1547 1402 1402
q18 7700 7622 7799 7622
q19 856 884 977 884
q20 2070 2125 1941 1941
q21 5872 5178 4993 4993
q22 1163 1139 1084 1084
Total cold run time: 53612 ms
Total hot run time: 51681 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2911070206
<details>
<summary>TPC-DS: <b>Total hot run time: 192858 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 885d3702646692487d57203f3934d473cdec56ec, data reload: false
query1 1418 1096 1085 1085
query2 6376 1843 1833 1833
query3 11016 4446 4362 4362
query4 54312 24205 23155 23155
query5 4994 522 485 485
query6 334 209 184 184
query7 4863 518 295 295
query8 307 239 233 233
query9 5471 2618 2625 2618
query10 452 357 278 278
query11 15079 14964 15025 14964
query12 170 112 105 105
query13 1047 543 414 414
query14 10086 6326 6290 6290
query15 209 203 177 177
query16 7176 656 508 508
query17 1112 753 606 606
query18 1641 428 341 341
query19 212 204 176 176
query20 126 124 133 124
query21 211 126 107 107
query22 4323 4479 4543 4479
query23 34475 33675 33632 33632
query24 6719 2395 2438 2395
query25 493 494 407 407
query26 704 276 160 160
query27 2380 512 337 337
query28 3422 2191 2160 2160
query29 588 589 479 479
query30 271 223 198 198
query31 854 837 790 790
query32 73 59 65 59
query33 442 359 309 309
query34 785 874 542 542
query35 796 839 780 780
query36 943 1017 919 919
query37 122 107 85 85
query38 4267 4321 4134 4134
query39 1521 1452 1647 1452
query40 216 125 114 114
query41 58 55 55 55
query42 127 119 112 112
query43 506 506 465 465
query44 1342 869 844 844
query45 187 174 168 168
query46 871 1044 689 689
query47 1847 1895 1840 1840
query48 403 476 365 365
query49 683 541 450 450
query50 670 699 418 418
query51 4306 4284 4253 4253
query52 113 107 105 105
query53 230 289 192 192
query54 585 583 514 514
query55 83 84 84 84
query56 345 336 316 316
query57 1181 1207 1143 1143
query58 272 256 264 256
query59 2782 2803 2711 2711
query60 328 337 316 316
query61 127 129 135 129
query62 689 722 671 671
query63 229 191 182 182
query64 1704 1045 729 729
query65 4270 4210 4211 4210
query66 707 400 297 297
query67 15896 15757 15457 15457
query68 7333 886 532 532
query69 569 305 274 274
query70 1204 1113 1035 1035
query71 505 324 335 324
query72 5807 4750 4749 4749
query73 1501 629 361 361
query74 8982 8823 8675 8675
query75 3833 3201 2688 2688
query76 4125 1214 761 761
query77 594 377 288 288
query78 10171 10148 9355 9355
query79 2519 818 575 575
query80 644 505 440 440
query81 484 260 214 214
query82 556 126 96 96
query83 246 251 234 234
query84 294 104 84 84
query85 803 364 321 321
query86 381 320 289 289
query87 4439 4383 4310 4310
query88 3461 2298 2298 2298
query89 412 325 277 277
query90 1865 199 204 199
query91 146 147 111 111
query92 77 64 57 57
query93 2320 916 579 579
query94 670 417 298 298
query95 366 295 286 286
query96 503 575 286 286
query97 2719 2755 2649 2649
query98 232 211 204 204
query99 1421 1391 1267 1267
Total cold run time: 299729 ms
Total hot run time: 192858 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919203213
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2451300534
<details>
<summary>TPC-DS: <b>Total hot run time: 196276 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false
query1 1218 904 897 897
query2 6259 2077 2091 2077
query3 10788 3896 3925 3896
query4 67879 29405 23628 23628
query5 5077 455 432 432
query6 403 164 159 159
query7 5649 294 302 294
query8 294 231 225 225
query9 9290 2765 2756 2756
query10 467 267 251 251
query11 17559 15490 15933 15490
query12 163 105 104 104
query13 1550 448 434 434
query14 10953 7088 6939 6939
query15 214 183 180 180
query16 7085 460 455 455
query17 1012 550 568 550
query18 1843 294 293 293
query19 193 152 150 150
query20 118 111 110 110
query21 203 98 109 98
query22 4620 4366 4417 4366
query23 34784 34192 34288 34192
query24 6016 2817 2849 2817
query25 522 401 409 401
query26 658 165 165 165
query27 1657 294 290 290
query28 4197 2488 2437 2437
query29 657 400 411 400
query30 231 151 147 147
query31 982 761 843 761
query32 67 54 56 54
query33 432 262 261 261
query34 936 508 528 508
query35 865 730 733 730
query36 1080 958 967 958
query37 111 71 73 71
query38 4442 4309 4237 4237
query39 1487 1447 1406 1406
query40 191 94 97 94
query41 45 41 43 41
query42 110 97 96 96
query43 552 504 507 504
query44 1173 807 826 807
query45 179 160 160 160
query46 1105 725 681 681
query47 1926 1882 1859 1859
query48 414 318 316 316
query49 715 394 386 386
query50 815 389 418 389
query51 7302 7179 7031 7031
query52 97 90 87 87
query53 270 182 180 180
query54 525 395 401 395
query55 77 77 76 76
query56 258 230 241 230
query57 1280 1218 1163 1163
query58 212 210 198 198
query59 3241 3146 2916 2916
query60 279 250 246 246
query61 98 98 103 98
query62 798 672 682 672
query63 216 191 197 191
query64 1348 617 627 617
query65 3269 3258 3250 3250
query66 720 296 333 296
query67 15966 15523 15815 15523
query68 2741 591 606 591
query69 404 255 250 250
query70 1177 1164 1145 1145
query71 318 253 257 253
query72 5462 4118 4053 4053
query73 760 366 363 363
query74 9659 8925 9183 8925
query75 3414 2644 2675 2644
query76 1615 1025 1148 1025
query77 522 280 280 280
query78 10319 9449 9419 9419
query79 1367 606 589 589
query80 817 431 441 431
query81 493 251 243 243
query82 1257 118 113 113
query83 212 147 139 139
query84 270 72 70 70
query85 846 292 283 283
query86 348 286 276 276
query87 4895 4714 4854 4714
query88 3318 2223 2172 2172
query89 411 299 297 297
query90 1977 185 186 185
query91 137 104 96 96
query92 60 49 49 49
query93 1297 536 542 536
query94 767 281 284 281
query95 348 243 244 243
query96 607 272 286 272
query97 2898 2705 2728 2705
query98 215 209 190 190
query99 1583 1323 1323 1323
Total cold run time: 315656 ms
Total hot run time: 196276 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2451291227
<details>
<summary>TPC-H: <b>Total hot run time: 41452 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false
------ Round 1 ----------------------------------
q1 17575 7751 7287 7287
q2 2055 168 176 168
q3 10541 1109 1217 1109
q4 10549 858 884 858
q5 7775 3110 3055 3055
q6 235 148 149 148
q7 1029 621 614 614
q8 9341 2004 1996 1996
q9 6642 6434 6468 6434
q10 7109 2458 2471 2458
q11 482 273 264 264
q12 410 215 214 214
q13 17788 3013 3003 3003
q14 264 208 222 208
q15 574 533 515 515
q16 689 609 597 597
q17 976 492 501 492
q18 7373 6748 6725 6725
q19 1343 1027 1084 1027
q20 495 187 185 185
q21 3979 3317 3081 3081
q22 1104 1017 1014 1014
Total cold run time: 108328 ms
Total hot run time: 41452 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7262 7241 7233 7233
q2 325 224 230 224
q3 3002 2965 3021 2965
q4 2115 1926 1797 1797
q5 5748 5784 5777 5777
q6 232 154 147 147
q7 2251 1899 1814 1814
q8 3384 3552 3448 3448
q9 8914 8976 8864 8864
q10 3608 3554 3566 3554
q11 608 513 510 510
q12 825 645 645 645
q13 9082 3209 3168 3168
q14 308 285 273 273
q15 589 523 531 523
q16 695 637 626 626
q17 1879 1652 1612 1612
q18 8505 7891 7648 7648
q19 1708 1547 1515 1515
q20 2133 1884 1881 1881
q21 5558 5394 5456 5394
q22 1162 1099 1041 1041
Total cold run time: 69893 ms
Total hot run time: 60659 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963715401
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -379,4 +397,16 @@ private ImmutableSet<Expression> getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+ private Map<Slot, Expression> generateMap(List<NamedExpression> namedExpressions) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2432022450
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2911077000
<details>
<summary>ClickBench: <b>Total hot run time: 28.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 885d3702646692487d57203f3934d473cdec56ec, data reload: false
query1 0.03 0.04 0.03
query2 0.13 0.10 0.12
query3 0.26 0.19 0.20
query4 1.60 0.19 0.11
query5 0.44 0.40 0.42
query6 1.15 0.66 0.65
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.58 0.51 0.51
query10 0.56 0.58 0.56
query11 0.15 0.12 0.11
query12 0.14 0.12 0.12
query13 0.61 0.60 0.59
query14 0.78 0.83 0.81
query15 0.88 0.84 0.86
query16 0.38 0.41 0.38
query17 1.06 1.09 1.03
query18 0.22 0.22 0.21
query19 1.90 1.91 1.92
query20 0.01 0.02 0.01
query21 15.39 0.93 0.56
query22 0.76 1.25 0.70
query23 14.85 1.37 0.62
query24 7.22 1.88 0.42
query25 0.49 0.27 0.07
query26 0.62 0.16 0.14
query27 0.05 0.04 0.05
query28 8.78 0.88 0.43
query29 12.54 4.04 3.36
query30 0.26 0.09 0.07
query31 2.81 0.59 0.38
query32 3.23 0.56 0.47
query33 3.14 3.04 3.06
query34 15.84 5.08 4.49
query35 4.52 4.53 4.47
query36 0.65 0.50 0.48
query37 0.08 0.06 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.16 0.14 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.03
query43 0.03 0.03 0.04
Total cold run time: 102.56 s
Total hot run time: 28.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2426098980
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2499651767
<details>
<summary>TPC-H: <b>Total hot run time: 41598 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false
------ Round 1 ----------------------------------
q1 17583 7890 8009 7890
q2 2044 178 169 169
q3 10776 1177 1266 1177
q4 10564 738 772 738
q5 7629 2879 2865 2865
q6 260 152 151 151
q7 1064 637 626 626
q8 9260 1870 2051 1870
q9 6973 6729 6698 6698
q10 7010 2352 2369 2352
q11 470 275 270 270
q12 454 227 219 219
q13 17772 3058 3040 3040
q14 258 210 207 207
q15 589 531 544 531
q16 684 600 582 582
q17 1032 534 557 534
q18 7316 6657 6815 6657
q19 1359 1130 1218 1130
q20 496 182 187 182
q21 4285 3545 3395 3395
q22 396 328 315 315
Total cold run time: 108274 ms
Total hot run time: 41598 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7836 7822 7990 7822
q2 357 243 237 237
q3 3202 3052 3111 3052
q4 2265 1970 1891 1891
q5 5782 5842 5916 5842
q6 251 146 148 146
q7 2365 1823 1804 1804
q8 3712 3796 3710 3710
q9 9165 9039 9029 9029
q10 3805 3709 3727 3709
q11 628 532 514 514
q12 861 623 589 589
q13 11252 3317 3292 3292
q14 333 295 293 293
q15 587 530 537 530
q16 704 637 658 637
q17 1985 1739 1718 1718
q18 8338 7757 7788 7757
q19 1898 1760 1758 1758
q20 2127 1892 1913 1892
q21 5814 5510 5541 5510
q22 676 577 573 573
Total cold run time: 73943 ms
Total hot run time: 62305 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2499664985
<details>
<summary>TPC-DS: <b>Total hot run time: 197942 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false
query1 1229 933 899 899
query2 6267 2145 2080 2080
query3 10952 3972 4041 3972
query4 67874 29187 23542 23542
query5 4829 466 467 466
query6 433 193 188 188
query7 5503 307 294 294
query8 313 230 219 219
query9 8715 2634 2645 2634
query10 442 261 250 250
query11 17228 15224 15940 15224
query12 149 106 105 105
query13 1477 408 415 408
query14 10030 7927 7934 7927
query15 208 201 205 201
query16 7038 466 467 466
query17 1195 558 568 558
query18 1794 297 303 297
query19 230 147 154 147
query20 120 120 113 113
query21 202 104 108 104
query22 4724 4624 4350 4350
query23 34934 34354 34417 34354
query24 5446 2517 2571 2517
query25 487 390 394 390
query26 645 156 153 153
query27 1810 292 290 290
query28 4666 2476 2473 2473
query29 677 409 427 409
query30 219 150 160 150
query31 1045 828 838 828
query32 67 52 55 52
query33 467 289 285 285
query34 946 533 523 523
query35 864 743 755 743
query36 1068 976 947 947
query37 122 84 72 72
query38 4526 4507 4349 4349
query39 1515 1515 1494 1494
query40 198 110 101 101
query41 44 40 44 40
query42 114 105 105 105
query43 553 491 521 491
query44 1203 835 834 834
query45 200 204 167 167
query46 1136 736 726 726
query47 2031 1882 1914 1882
query48 423 317 333 317
query49 724 408 396 396
query50 840 396 423 396
query51 7465 7279 7290 7279
query52 104 95 85 85
query53 261 187 174 174
query54 518 391 397 391
query55 85 77 77 77
query56 252 241 243 241
query57 1290 1179 1174 1174
query58 230 223 227 223
query59 3337 3180 3180 3180
query60 285 258 250 250
query61 133 127 127 127
query62 808 676 682 676
query63 217 194 191 191
query64 1464 662 631 631
query65 3280 3183 3245 3183
query66 706 305 326 305
query67 15969 15737 15627 15627
query68 4073 574 562 562
query69 419 253 251 251
query70 1225 1064 1093 1064
query71 356 262 255 255
query72 6313 4073 4015 4015
query73 772 350 368 350
query74 10508 9073 9089 9073
query75 3392 2682 2789 2682
query76 1805 1134 1132 1132
query77 446 280 277 277
query78 10418 9455 9376 9376
query79 2221 591 607 591
query80 1426 424 436 424
query81 535 240 231 231
query82 1314 123 126 123
query83 269 155 146 146
query84 276 70 73 70
query85 1146 331 290 290
query86 435 302 304 302
query87 4870 4656 4625 4625
query88 3570 2256 2218 2218
query89 425 291 293 291
query90 1929 189 186 186
query91 136 102 105 102
query92 64 49 51 49
query93 3104 550 534 534
query94 873 306 275 275
query95 356 247 255 247
query96 632 282 282 282
query97 2928 2680 2702 2680
query98 222 193 199 193
query99 1666 1317 1304 1304
Total cold run time: 322450 ms
Total hot run time: 197942 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2673971987
<details>
<summary>TPC-H: <b>Total hot run time: 31065 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false
------ Round 1 ----------------------------------
q1 17593 5290 5058 5058
q2 2041 319 172 172
q3 10398 1244 724 724
q4 10202 1020 534 534
q5 7525 2479 2231 2231
q6 183 165 130 130
q7 910 732 592 592
q8 9277 1321 1184 1184
q9 4867 4598 4512 4512
q10 6826 2303 1880 1880
q11 477 285 249 249
q12 357 388 225 225
q13 17749 3704 3060 3060
q14 233 231 202 202
q15 500 449 459 449
q16 633 601 563 563
q17 565 853 324 324
q18 6491 6171 6101 6101
q19 1635 932 534 534
q20 304 315 189 189
q21 2655 2143 1856 1856
q22 353 338 296 296
Total cold run time: 101774 ms
Total hot run time: 31065 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5130 5083 5109 5083
q2 234 331 237 237
q3 2184 2699 2301 2301
q4 1445 1795 1363 1363
q5 4190 4106 4180 4106
q6 203 165 125 125
q7 1887 1837 1657 1657
q8 2535 2526 2543 2526
q9 7242 7271 7198 7198
q10 3030 3200 2813 2813
q11 564 519 484 484
q12 695 784 634 634
q13 3456 3887 3273 3273
q14 279 288 265 265
q15 495 458 450 450
q16 647 680 656 656
q17 1126 1581 1332 1332
q18 7560 7347 7252 7252
q19 783 815 990 815
q20 1947 2030 1892 1892
q21 5322 4953 4815 4815
q22 618 565 539 539
Total cold run time: 51572 ms
Total hot run time: 49816 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2900796869
<details>
<summary>ClickBench: <b>Total hot run time: 29.22 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b0b16ad101792258253d8356d2b35a511bbfef5b, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.11
query3 0.26 0.19 0.19
query4 1.59 0.19 0.11
query5 0.42 0.41 0.41
query6 1.14 0.66 0.67
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.57 0.52 0.52
query10 0.57 0.58 0.57
query11 0.16 0.11 0.11
query12 0.14 0.11 0.12
query13 0.61 0.60 0.60
query14 0.80 0.81 0.81
query15 0.89 0.86 0.87
query16 0.38 0.40 0.39
query17 1.05 1.07 1.03
query18 0.22 0.21 0.21
query19 1.96 1.79 1.83
query20 0.02 0.01 0.02
query21 15.39 0.92 0.54
query22 0.76 1.23 0.72
query23 14.82 1.40 0.65
query24 6.61 2.28 0.98
query25 0.52 0.07 0.06
query26 0.59 0.16 0.13
query27 0.04 0.06 0.05
query28 10.29 0.92 0.44
query29 12.54 3.90 3.27
query30 0.25 0.09 0.07
query31 2.83 0.58 0.39
query32 3.23 0.56 0.47
query33 3.00 3.07 3.10
query34 15.88 5.12 4.51
query35 4.53 4.52 4.50
query36 0.67 0.51 0.48
query37 0.08 0.06 0.06
query38 0.06 0.04 0.05
query39 0.03 0.02 0.02
query40 0.17 0.14 0.14
query41 0.08 0.03 0.02
query42 0.03 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 103.44 s
Total hot run time: 29.22 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2901065905
<details>
<summary>TPC-H: <b>Total hot run time: 33685 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 864d403a4b52b10fbe491c24bc8a625494db2584, data reload: false
------ Round 1 ----------------------------------
q1 26410 5043 4935 4935
q2 2065 303 189 189
q3 10357 1205 682 682
q4 10246 1015 524 524
q5 7529 2371 2336 2336
q6 176 165 132 132
q7 893 723 615 615
q8 9313 1248 1094 1094
q9 6807 5064 5136 5064
q10 6831 2289 1874 1874
q11 482 283 270 270
q12 339 353 208 208
q13 17769 3701 3056 3056
q14 232 221 209 209
q15 551 505 509 505
q16 413 422 367 367
q17 578 860 358 358
q18 7526 7224 7182 7182
q19 1081 923 548 548
q20 349 349 230 230
q21 3743 3127 2349 2349
q22 1069 1022 958 958
Total cold run time: 114759 ms
Total hot run time: 33685 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5049 5054 5079 5054
q2 244 324 230 230
q3 2145 2618 2270 2270
q4 1318 1779 1383 1383
q5 4455 4440 4402 4402
q6 224 172 130 130
q7 1995 1915 1742 1742
q8 2615 2479 2584 2479
q9 7224 7147 7215 7147
q10 2952 3236 2687 2687
q11 568 508 513 508
q12 689 780 588 588
q13 3457 3866 3303 3303
q14 282 287 266 266
q15 555 508 505 505
q16 436 471 434 434
q17 1136 1470 1368 1368
q18 7728 7549 7319 7319
q19 775 765 873 765
q20 1974 2010 1846 1846
q21 4881 4240 4365 4240
q22 1072 1031 1009 1009
Total cold run time: 51774 ms
Total hot run time: 49675 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2606273695
<details>
<summary>TPC-H: <b>Total hot run time: 32592 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false
------ Round 1 ----------------------------------
q1 17631 5582 5429 5429
q2 2048 307 172 172
q3 10407 1263 711 711
q4 10218 956 526 526
q5 7537 2407 2205 2205
q6 192 170 134 134
q7 953 750 623 623
q8 9233 1382 1218 1218
q9 5189 4995 4956 4956
q10 6832 2323 1909 1909
q11 471 269 250 250
q12 345 364 219 219
q13 17790 3775 3194 3194
q14 228 229 211 211
q15 509 471 466 466
q16 635 625 598 598
q17 550 858 319 319
q18 7094 6558 6430 6430
q19 1227 963 533 533
q20 305 332 193 193
q21 2857 2237 1982 1982
q22 367 339 314 314
Total cold run time: 102618 ms
Total hot run time: 32592 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5528 5488 5509 5488
q2 243 341 239 239
q3 2250 2671 2329 2329
q4 1405 1842 1387 1387
q5 4312 4757 4652 4652
q6 165 155 123 123
q7 2084 2023 1834 1834
q8 2624 2804 2694 2694
q9 7332 7243 7179 7179
q10 2999 3270 2761 2761
q11 587 528 509 509
q12 690 784 605 605
q13 3497 3926 3368 3368
q14 278 292 268 268
q15 517 488 471 471
q16 661 694 648 648
q17 1238 1723 1266 1266
q18 7796 7430 7352 7352
q19 790 1091 1119 1091
q20 1972 2027 1888 1888
q21 5611 5254 4865 4865
q22 603 623 555 555
Total cold run time: 53182 ms
Total hot run time: 51572 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2606290847
<details>
<summary>ClickBench: <b>Total hot run time: 30.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false
query1 0.03 0.03 0.03
query2 0.08 0.03 0.03
query3 0.24 0.07 0.07
query4 1.61 0.10 0.10
query5 0.44 0.40 0.40
query6 1.17 0.66 0.66
query7 0.03 0.02 0.02
query8 0.04 0.03 0.03
query9 0.58 0.52 0.50
query10 0.56 0.56 0.54
query11 0.15 0.10 0.10
query12 0.14 0.11 0.12
query13 0.61 0.59 0.60
query14 2.85 2.77 2.75
query15 0.91 0.82 0.82
query16 0.39 0.39 0.37
query17 1.02 1.06 1.03
query18 0.23 0.22 0.21
query19 1.96 1.79 1.97
query20 0.01 0.01 0.01
query21 15.36 0.94 0.57
query22 0.76 0.82 0.67
query23 15.26 1.49 0.52
query24 2.94 0.72 1.22
query25 0.12 0.08 0.13
query26 0.36 0.15 0.14
query27 0.07 0.06 0.06
query28 13.72 1.06 0.43
query29 12.56 3.91 3.30
query30 0.25 0.08 0.05
query31 2.85 0.60 0.39
query32 3.22 0.54 0.46
query33 3.01 2.97 3.06
query34 16.48 5.19 4.49
query35 4.55 4.52 4.50
query36 0.64 0.49 0.48
query37 0.10 0.07 0.06
query38 0.04 0.03 0.03
query39 0.03 0.03 0.02
query40 0.16 0.13 0.13
query41 0.08 0.03 0.02
query42 0.04 0.03 0.02
query43 0.04 0.03 0.02
Total cold run time: 105.69 s
Total hot run time: 30.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2901120110
<details>
<summary>ClickBench: <b>Total hot run time: 29.12 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 864d403a4b52b10fbe491c24bc8a625494db2584, data reload: false
query1 0.03 0.03 0.03
query2 0.12 0.11 0.10
query3 0.26 0.19 0.20
query4 1.60 0.19 0.19
query5 0.45 0.44 0.44
query6 1.17 0.66 0.65
query7 0.02 0.02 0.02
query8 0.04 0.03 0.04
query9 0.59 0.53 0.52
query10 0.55 0.57 0.56
query11 0.16 0.11 0.11
query12 0.16 0.12 0.12
query13 0.61 0.61 0.60
query14 0.83 0.78 0.81
query15 0.88 0.87 0.86
query16 0.38 0.38 0.39
query17 1.01 1.03 1.00
query18 0.22 0.21 0.21
query19 1.90 1.79 1.85
query20 0.02 0.01 0.01
query21 15.40 0.89 0.54
query22 0.75 1.21 0.94
query23 14.70 1.40 0.61
query24 7.61 1.17 0.76
query25 0.49 0.19 0.07
query26 0.66 0.17 0.14
query27 0.05 0.05 0.04
query28 9.22 0.87 0.45
query29 12.60 4.04 3.28
query30 0.25 0.09 0.07
query31 2.83 0.61 0.38
query32 3.23 0.56 0.47
query33 3.15 3.07 3.06
query34 15.77 5.10 4.46
query35 4.48 4.53 4.47
query36 0.66 0.49 0.48
query37 0.09 0.07 0.06
query38 0.05 0.04 0.04
query39 0.04 0.03 0.02
query40 0.16 0.14 0.13
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.34 s
Total hot run time: 29.12 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919244885
<details>
<summary>TPC-H: <b>Total hot run time: 33570 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4fe644a3df8e11f5ff5aa4a3963e2788d3d73a2c, data reload: false
------ Round 1 ----------------------------------
q1 26368 5046 5005 5005
q2 1969 288 187 187
q3 10268 1211 713 713
q4 10234 998 520 520
q5 7552 2367 2288 2288
q6 177 162 133 133
q7 900 748 603 603
q8 9314 1228 1017 1017
q9 6789 5066 5035 5035
q10 6870 2340 1905 1905
q11 477 289 281 281
q12 346 351 212 212
q13 17780 3731 3109 3109
q14 228 238 224 224
q15 570 485 475 475
q16 417 434 372 372
q17 583 854 358 358
q18 7608 7224 7061 7061
q19 1813 949 567 567
q20 333 333 225 225
q21 3757 3119 2308 2308
q22 1054 1024 972 972
Total cold run time: 115407 ms
Total hot run time: 33570 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5216 5087 5061 5061
q2 242 320 220 220
q3 2147 2651 2283 2283
q4 1360 1761 1338 1338
q5 4399 4411 4430 4411
q6 223 167 123 123
q7 2024 1884 1778 1778
q8 2582 2610 2565 2565
q9 7308 7163 6954 6954
q10 3012 3205 2781 2781
q11 576 510 492 492
q12 689 756 614 614
q13 3561 3952 3337 3337
q14 284 287 295 287
q15 531 481 489 481
q16 453 482 437 437
q17 1165 1555 1377 1377
q18 7691 7514 7514 7514
q19 841 859 983 859
q20 2006 2109 1856 1856
q21 4741 4509 4408 4408
q22 1088 1074 1031 1031
Total cold run time: 52139 ms
Total hot run time: 50207 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919282847
<details>
<summary>ClickBench: <b>Total hot run time: 29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4fe644a3df8e11f5ff5aa4a3963e2788d3d73a2c, data reload: false
query1 0.04 0.04 0.02
query2 0.14 0.11 0.11
query3 0.25 0.19 0.20
query4 1.59 0.19 0.19
query5 0.45 0.45 0.43
query6 1.17 0.67 0.67
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.58 0.52 0.53
query10 0.57 0.58 0.56
query11 0.16 0.11 0.11
query12 0.15 0.12 0.11
query13 0.62 0.60 0.59
query14 0.80 0.82 0.80
query15 0.88 0.86 0.86
query16 0.37 0.39 0.37
query17 1.03 1.03 1.06
query18 0.23 0.21 0.20
query19 1.96 1.84 1.88
query20 0.01 0.01 0.01
query21 15.40 0.93 0.54
query22 0.74 1.16 0.70
query23 14.93 1.39 0.65
query24 6.92 1.10 0.58
query25 0.49 0.12 0.15
query26 0.68 0.17 0.13
query27 0.06 0.05 0.06
query28 9.54 0.90 0.45
query29 12.64 4.02 3.32
query30 0.26 0.10 0.07
query31 2.81 0.56 0.38
query32 3.23 0.55 0.46
query33 3.07 3.08 3.10
query34 15.88 5.09 4.50
query35 4.52 4.57 4.50
query36 0.67 0.51 0.48
query37 0.09 0.06 0.07
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.17 0.14 0.13
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 103.4 s
Total hot run time: 29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2673997853
<details>
<summary>TPC-DS: <b>Total hot run time: 189746 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false
query1 1315 963 936 936
query2 6249 1848 1906 1848
query3 11119 4457 4480 4457
query4 56929 24195 23195 23195
query5 5103 549 514 514
query6 391 203 189 189
query7 5264 502 289 289
query8 320 246 233 233
query9 6587 2582 2595 2582
query10 423 312 266 266
query11 15163 15095 14845 14845
query12 166 106 111 106
query13 1274 504 403 403
query14 10577 6315 6390 6315
query15 211 205 191 191
query16 7025 658 493 493
query17 1054 732 578 578
query18 1538 429 319 319
query19 223 220 169 169
query20 132 134 127 127
query21 204 125 114 114
query22 4411 4578 4446 4446
query23 34057 33321 33635 33321
query24 5574 2401 2453 2401
query25 445 470 409 409
query26 667 274 159 159
query27 1697 472 335 335
query28 2985 2487 2411 2411
query29 545 568 444 444
query30 206 190 153 153
query31 897 860 798 798
query32 72 62 59 59
query33 438 363 304 304
query34 779 839 525 525
query35 801 839 773 773
query36 957 980 924 924
query37 119 97 74 74
query38 4333 4350 4249 4249
query39 1496 1436 1436 1436
query40 201 112 101 101
query41 53 50 50 50
query42 119 99 111 99
query43 501 517 498 498
query44 1296 814 791 791
query45 191 182 168 168
query46 874 1055 665 665
query47 1852 1863 1785 1785
query48 405 427 314 314
query49 698 523 430 430
query50 741 771 426 426
query51 4287 4258 4238 4238
query52 113 107 96 96
query53 227 256 184 184
query54 483 502 425 425
query55 83 79 87 79
query56 276 265 260 260
query57 1172 1190 1077 1077
query58 259 238 232 232
query59 2732 2837 2676 2676
query60 292 298 268 268
query61 121 114 119 114
query62 727 730 674 674
query63 232 195 193 193
query64 1414 1006 652 652
query65 3166 3163 3164 3163
query66 700 415 294 294
query67 15927 15675 15339 15339
query68 5371 763 508 508
query69 553 307 256 256
query70 1222 1136 1102 1102
query71 461 282 251 251
query72 5931 3627 3711 3627
query73 1063 737 349 349
query74 9133 9086 9011 9011
query75 3237 3123 2694 2694
query76 3904 1164 718 718
query77 560 378 278 278
query78 9898 10146 9365 9365
query79 2365 819 600 600
query80 593 535 440 440
query81 509 286 237 237
query82 204 126 95 95
query83 173 171 154 154
query84 290 90 70 70
query85 769 345 301 301
query86 373 318 286 286
query87 4683 4446 4319 4319
query88 3750 2208 2270 2208
query89 420 321 289 289
query90 1813 191 188 188
query91 133 136 107 107
query92 80 58 51 51
query93 2035 1054 569 569
query94 645 411 291 291
query95 341 264 255 255
query96 502 543 290 290
query97 2841 2840 2706 2706
query98 233 197 201 197
query99 1320 1412 1253 1253
Total cold run time: 296293 ms
Total hot run time: 189746 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2803756102
<details>
<summary>ClickBench: <b>Total hot run time: 31.1 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d131b92e19dabb9652588d7253de5ad3077f2b9b, data reload: false
query1 0.04 0.04 0.03
query2 0.13 0.10 0.12
query3 0.25 0.20 0.20
query4 1.59 0.20 0.19
query5 0.60 0.58 0.60
query6 1.17 0.70 0.73
query7 0.02 0.02 0.01
query8 0.04 0.03 0.04
query9 0.57 0.54 0.53
query10 0.56 0.57 0.57
query11 0.16 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.60 0.58
query14 2.70 2.69 2.79
query15 0.92 0.83 0.86
query16 0.38 0.37 0.39
query17 1.04 1.06 1.05
query18 0.21 0.19 0.20
query19 1.90 1.91 1.87
query20 0.01 0.01 0.01
query21 15.36 0.90 0.55
query22 0.76 1.32 0.65
query23 14.80 1.40 0.65
query24 6.70 0.87 0.84
query25 0.50 0.24 0.14
query26 0.58 0.17 0.14
query27 0.05 0.05 0.05
query28 9.62 0.93 0.43
query29 12.63 4.00 3.26
query30 0.24 0.08 0.06
query31 2.83 0.61 0.38
query32 3.22 0.54 0.46
query33 3.01 3.03 3.03
query34 15.81 5.05 4.46
query35 4.48 4.55 4.45
query36 0.66 0.49 0.49
query37 0.09 0.06 0.06
query38 0.05 0.03 0.04
query39 0.04 0.03 0.02
query40 0.17 0.14 0.13
query41 0.08 0.03 0.02
query42 0.04 0.03 0.02
query43 0.03 0.03 0.03
Total cold run time: 104.79 s
Total hot run time: 31.1 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994634619
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression> getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2451236612
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2432247596
<details>
<summary>TPC-DS: <b>Total hot run time: 192714 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false
query1 955 381 384 381
query2 5355 2211 2146 2146
query3 4664 216 226 216
query4 33280 23714 23579 23579
query5 3594 473 501 473
query6 237 169 158 158
query7 4032 299 300 299
query8 306 237 228 228
query9 8663 2717 2760 2717
query10 441 301 286 286
query11 17718 15158 15189 15158
query12 152 106 103 103
query13 1472 439 427 427
query14 9627 7130 7136 7130
query15 266 175 175 175
query16 7373 460 459 459
query17 1340 577 562 562
query18 1818 322 308 308
query19 279 152 148 148
query20 127 116 108 108
query21 216 109 103 103
query22 4722 4234 4366 4234
query23 35102 34487 34281 34281
query24 10723 2763 2815 2763
query25 691 412 409 409
query26 1711 160 173 160
query27 2619 284 285 284
query28 7400 2467 2467 2467
query29 1018 440 432 432
query30 334 166 156 156
query31 1038 813 855 813
query32 80 57 60 57
query33 698 290 305 290
query34 954 505 525 505
query35 961 755 765 755
query36 1130 946 963 946
query37 246 91 92 91
query38 4163 3905 3952 3905
query39 1496 1433 1493 1433
query40 279 103 105 103
query41 50 48 47 47
query42 121 99 101 99
query43 550 516 500 500
query44 1257 825 821 821
query45 206 170 173 170
query46 1161 715 706 706
query47 1922 1824 1822 1822
query48 433 326 324 324
query49 1258 452 443 443
query50 831 389 408 389
query51 7168 7034 7016 7016
query52 102 94 93 93
query53 259 187 181 181
query54 842 440 451 440
query55 81 79 80 79
query56 289 270 275 270
query57 1332 1181 1169 1169
query58 242 283 287 283
query59 3498 3043 3090 3043
query60 305 292 287 287
query61 154 100 107 100
query62 862 691 661 661
query63 217 186 185 185
query64 4602 656 615 615
query65 3277 3181 3248 3181
query66 1311 318 304 304
query67 16038 15952 15636 15636
query68 4256 574 550 550
query69 534 296 297 296
query70 1217 1151 1191 1151
query71 364 283 265 265
query72 6667 3954 4024 3954
query73 784 363 375 363
query74 9579 9118 9103 9103
query75 3405 2642 2700 2642
query76 3341 876 924 876
query77 411 320 305 305
query78 10468 9678 9655 9655
query79 1136 598 617 598
query80 2040 474 453 453
query81 579 243 245 243
query82 349 141 144 141
query83 282 136 136 136
query84 268 70 73 70
query85 1360 296 280 280
query86 394 307 305 305
query87 4581 4437 4516 4437
query88 3479 2239 2207 2207
query89 392 289 291 289
query90 2149 194 183 183
query91 143 101 101 101
query92 74 50 48 48
query93 1095 558 544 544
query94 1134 283 294 283
query95 349 253 258 253
query96 612 279 287 279
query97 3294 3151 3096 3096
query98 214 195 199 195
query99 1503 1307 1301 1301
Total cold run time: 292101 ms
Total hot run time: 192714 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r2108046464
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression> getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
median, any_value are also can pull up ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2910936757
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919848139
<details>
<summary>TPC-DS: <b>Total hot run time: 192119 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21ad56da2abc20ff3f55cae77e2bf8cafa70d4ba, data reload: false
query1 1407 1082 1063 1063
query2 6379 1781 1789 1781
query3 10993 4504 4453 4453
query4 55135 25562 23478 23478
query5 5309 480 459 459
query6 351 210 217 210
query7 4880 522 284 284
query8 277 235 209 209
query9 5797 2643 2633 2633
query10 465 329 267 267
query11 15047 15064 14780 14780
query12 161 112 107 107
query13 1055 526 410 410
query14 10153 6257 6332 6257
query15 215 209 196 196
query16 7177 680 461 461
query17 1073 759 595 595
query18 1679 434 358 358
query19 209 210 177 177
query20 132 125 116 116
query21 213 131 109 109
query22 4428 4607 4601 4601
query23 34313 33358 33715 33358
query24 6520 2451 2412 2412
query25 462 475 396 396
query26 699 276 153 153
query27 2470 508 338 338
query28 3265 2166 2195 2166
query29 579 560 465 465
query30 270 218 199 199
query31 881 876 781 781
query32 73 64 62 62
query33 449 362 318 318
query34 770 871 540 540
query35 762 814 754 754
query36 967 1019 887 887
query37 110 105 78 78
query38 4264 4346 4196 4196
query39 1489 1443 1492 1443
query40 207 122 112 112
query41 60 56 55 55
query42 122 108 110 108
query43 511 499 480 480
query44 1351 843 884 843
query45 182 171 170 170
query46 868 1048 675 675
query47 1861 1933 1893 1893
query48 389 424 334 334
query49 658 486 406 406
query50 673 698 409 409
query51 4189 4359 4220 4220
query52 112 112 99 99
query53 225 261 181 181
query54 567 583 520 520
query55 86 81 84 81
query56 293 297 291 291
query57 1180 1188 1085 1085
query58 258 249 244 244
query59 2534 2575 2573 2573
query60 321 319 299 299
query61 125 126 122 122
query62 703 718 643 643
query63 222 181 178 178
query64 1716 1013 675 675
query65 4183 4150 4123 4123
query66 707 438 299 299
query67 16001 15673 15357 15357
query68 8899 869 528 528
query69 545 359 265 265
query70 1186 1068 1095 1068
query71 483 320 299 299
query72 5534 4756 4604 4604
query73 1432 656 359 359
query74 8903 9086 8768 8768
query75 3867 3222 2627 2627
query76 4211 1192 753 753
query77 621 390 279 279
query78 10128 10260 9367 9367
query79 2204 797 580 580
query80 618 525 431 431
query81 476 267 223 223
query82 419 126 93 93
query83 382 253 233 233
query84 294 109 85 85
query85 808 353 406 353
query86 378 303 281 281
query87 4440 4409 4331 4331
query88 3338 2282 2282 2282
query89 398 312 289 289
query90 1947 206 201 201
query91 153 142 175 142
query92 69 58 58 58
query93 1164 935 581 581
query94 700 391 310 310
query95 366 290 279 279
query96 492 555 281 281
query97 2724 2810 2657 2657
query98 224 204 213 204
query99 1490 1428 1283 1283
Total cold run time: 300075 ms
Total hot run time: 192119 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994637970
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression> getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963465068
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -273,24 +284,31 @@ public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Pla
public ImmutableSet<Expression> visitLogicalAggregate(LogicalAggregate<? extends Plan> aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet<Expression> childPredicates = aggregate.child().accept(this, context);
- // TODO
List<NamedExpression> outputExpressions = aggregate.getOutputExpressions();
-
- Map<Expression, Slot> expressionSlotMap
- = Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+ Map<Expression, List<Slot>> expressionSlotMap
+ = Maps.newHashMapWithExpectedSize(outputExpressions.size());
for (NamedExpression output : outputExpressions) {
- if (hasAgg(output)) {
- expressionSlotMap.putIfAbsent(
- output instanceof Alias ? output.child(0) : output, output.toSlot()
- );
+ if (output instanceof Alias && supportPullUpAgg(output.child(0))) {
+ expressionSlotMap.computeIfAbsent(output.child(0).child(0),
+ k -> new ArrayList<>()).add(output.toSlot());
+ }
Review Comment:
these function only has one child:min,max,avg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2658474337
@xzj7019 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2434155845
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "xzj7019 (via GitHub)" <gi...@apache.org>.
xzj7019 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1820894518
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression> getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
Does it mean the original hasAgg judgement actually contains any unexpected pulled up agg cases, after this restriction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2426253041
<details>
<summary>TPC-H: <b>Total hot run time: 41433 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false
------ Round 1 ----------------------------------
q1 17654 7691 7268 7268
q2 2024 295 278 278
q3 12375 1082 1163 1082
q4 10565 837 868 837
q5 7757 3109 3102 3102
q6 239 155 149 149
q7 1031 624 606 606
q8 9359 1981 1991 1981
q9 6660 6479 6396 6396
q10 7070 2417 2415 2415
q11 451 241 245 241
q12 428 221 228 221
q13 17801 3045 3021 3021
q14 243 210 213 210
q15 576 520 507 507
q16 643 595 590 590
q17 986 470 456 456
q18 7213 6823 6847 6823
q19 1355 914 1062 914
q20 490 187 186 186
q21 4020 3337 3162 3162
q22 1105 1016 988 988
Total cold run time: 110045 ms
Total hot run time: 41433 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7301 7281 7307 7281
q2 331 246 245 245
q3 3083 2981 2990 2981
q4 2091 1755 1831 1755
q5 5749 5807 5820 5807
q6 232 149 149 149
q7 2294 1870 1879 1870
q8 3409 3430 3543 3430
q9 8965 8929 8984 8929
q10 3621 3582 3621 3582
q11 595 487 506 487
q12 847 674 627 627
q13 8713 3229 3266 3229
q14 311 273 272 272
q15 574 512 534 512
q16 707 665 643 643
q17 1850 1612 1591 1591
q18 8340 7766 7614 7614
q19 1736 1606 1532 1532
q20 2116 1876 1872 1872
q21 5803 5446 5482 5446
q22 1189 1091 1077 1077
Total cold run time: 69857 ms
Total hot run time: 60931 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2499613396
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919271721
<details>
<summary>TPC-DS: <b>Total hot run time: 192709 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4fe644a3df8e11f5ff5aa4a3963e2788d3d73a2c, data reload: false
query1 1418 1087 1056 1056
query2 6276 1788 1773 1773
query3 11002 4483 4560 4483
query4 53133 25371 23299 23299
query5 5196 541 459 459
query6 342 217 209 209
query7 4888 507 299 299
query8 281 236 209 209
query9 5703 2656 2659 2656
query10 415 346 295 295
query11 14942 14966 14804 14804
query12 156 111 108 108
query13 1044 548 422 422
query14 10208 6282 6231 6231
query15 211 209 178 178
query16 7006 659 463 463
query17 1076 723 592 592
query18 1511 417 315 315
query19 195 212 164 164
query20 125 116 124 116
query21 202 126 117 117
query22 4414 4536 4286 4286
query23 34415 33542 33682 33542
query24 6572 2467 2430 2430
query25 495 482 404 404
query26 647 280 167 167
query27 2240 518 362 362
query28 2890 2188 2139 2139
query29 580 573 440 440
query30 278 228 196 196
query31 862 848 783 783
query32 74 64 62 62
query33 453 364 316 316
query34 802 881 566 566
query35 797 844 771 771
query36 942 1003 891 891
query37 111 99 77 77
query38 4225 4270 4276 4270
query39 1753 1461 1460 1460
query40 213 132 107 107
query41 76 68 59 59
query42 134 114 115 114
query43 514 510 473 473
query44 1405 876 869 869
query45 184 178 165 165
query46 896 1031 668 668
query47 1878 1858 1774 1774
query48 408 462 350 350
query49 683 452 428 428
query50 686 718 423 423
query51 4214 4211 4214 4211
query52 110 118 113 113
query53 245 268 196 196
query54 601 609 517 517
query55 84 85 87 85
query56 325 314 303 303
query57 1167 1189 1123 1123
query58 266 261 264 261
query59 2725 2751 2632 2632
query60 343 320 314 314
query61 130 129 120 120
query62 768 741 679 679
query63 230 196 200 196
query64 1464 1005 680 680
query65 4231 4147 4178 4147
query66 711 395 300 300
query67 15804 15487 15352 15352
query68 5436 849 526 526
query69 518 300 282 282
query70 1186 1088 1023 1023
query71 449 334 307 307
query72 5915 5075 4908 4908
query73 1312 701 363 363
query74 9211 9174 8858 8858
query75 3310 3206 2709 2709
query76 3776 1189 775 775
query77 534 376 299 299
query78 10090 10200 9330 9330
query79 3092 848 591 591
query80 858 510 488 488
query81 518 256 218 218
query82 692 127 94 94
query83 267 257 239 239
query84 299 220 91 91
query85 792 352 325 325
query86 451 290 274 274
query87 4356 4396 4405 4396
query88 3449 2304 2306 2304
query89 413 326 291 291
query90 1760 212 206 206
query91 142 151 115 115
query92 74 59 60 59
query93 2519 948 580 580
query94 764 405 291 291
query95 370 293 302 293
query96 503 584 282 282
query97 2714 2754 2664 2664
query98 238 206 203 203
query99 1397 1388 1256 1256
Total cold run time: 295780 ms
Total hot run time: 192709 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2606285826
<details>
<summary>TPC-DS: <b>Total hot run time: 186664 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7e6e02ce3437d56f29abf375f41f696c6d5f6383, data reload: false
query1 972 381 363 363
query2 6509 2032 1920 1920
query3 6794 214 211 211
query4 33296 23269 22924 22924
query5 4376 619 464 464
query6 312 198 187 187
query7 4599 492 315 315
query8 307 246 231 231
query9 9283 2596 2590 2590
query10 493 334 274 274
query11 17817 15231 14864 14864
query12 154 107 108 107
query13 1659 554 408 408
query14 10359 7308 6679 6679
query15 259 197 183 183
query16 7922 645 478 478
query17 1644 725 549 549
query18 1971 378 285 285
query19 221 180 153 153
query20 112 112 136 112
query21 209 129 99 99
query22 4248 4339 4110 4110
query23 33938 32933 33185 32933
query24 6417 2218 2283 2218
query25 501 460 371 371
query26 1194 272 155 155
query27 1999 472 337 337
query28 5126 2432 2384 2384
query29 658 559 412 412
query30 237 185 155 155
query31 949 862 805 805
query32 91 60 65 60
query33 523 368 305 305
query34 753 834 507 507
query35 802 816 740 740
query36 982 1031 959 959
query37 130 98 74 74
query38 4180 4125 4132 4125
query39 1467 1392 1407 1392
query40 209 111 105 105
query41 54 53 52 52
query42 121 102 110 102
query43 525 502 477 477
query44 1346 799 818 799
query45 181 172 165 165
query46 854 1024 634 634
query47 1847 1811 1797 1797
query48 384 386 304 304
query49 785 488 391 391
query50 631 683 395 395
query51 7049 6983 6835 6835
query52 101 96 90 90
query53 219 251 184 184
query54 488 496 406 406
query55 81 81 78 78
query56 261 251 250 250
query57 1155 1175 1056 1056
query58 244 228 241 228
query59 2977 3191 2920 2920
query60 288 278 256 256
query61 119 118 121 118
query62 794 711 657 657
query63 224 193 192 192
query64 4319 1059 652 652
query65 3247 3156 3162 3156
query66 1082 413 315 315
query67 16042 15636 15464 15464
query68 5762 822 525 525
query69 491 298 265 265
query70 1248 1115 1085 1085
query71 386 291 260 260
query72 5899 3822 3835 3822
query73 653 758 367 367
query74 10315 9006 8866 8866
query75 3188 3201 2665 2665
query76 3234 1210 752 752
query77 482 349 289 289
query78 10068 10094 9241 9241
query79 3354 809 595 595
query80 598 524 451 451
query81 514 287 243 243
query82 589 145 121 121
query83 173 173 157 157
query84 237 100 77 77
query85 798 379 310 310
query86 404 317 310 310
query87 4466 4455 4403 4403
query88 4887 2130 2133 2130
query89 402 336 284 284
query90 1852 189 193 189
query91 136 140 114 114
query92 70 59 54 54
query93 1949 866 537 537
query94 706 408 299 299
query95 342 262 263 262
query96 494 619 278 278
query97 2789 2850 2746 2746
query98 237 208 197 197
query99 1267 1395 1254 1254
Total cold run time: 287080 ms
Total hot run time: 186664 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1955739668
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -379,4 +397,16 @@ private ImmutableSet<Expression> getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+ private Map<Slot, Expression> generateMap(List<NamedExpression> namedExpressions) {
Review Comment:
could u add some comment to explain the purpose of this replace map
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -379,4 +397,16 @@ private ImmutableSet<Expression> getFiltersFromUnionConstExprs(LogicalUnion unio
}
return ImmutableSet.copyOf(filtersFromConstExprs);
}
+
+ private Map<Slot, Expression> generateMap(List<NamedExpression> namedExpressions) {
+ Map<Slot, Expression> replaceMap = new LinkedHashMap<>(namedExpressions.size());
+ for (NamedExpression namedExpression : namedExpressions) {
+ if (namedExpression instanceof Alias) {
+ replaceMap.putIfAbsent(namedExpression.toSlot(), namedExpression.child(0));
+ } else if (namedExpression instanceof SlotReference) {
+ replaceMap.putIfAbsent((Slot) namedExpression, namedExpression);
Review Comment:
why put a entry with same key and value? i think it is not necessary
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -273,24 +284,31 @@ public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Pla
public ImmutableSet<Expression> visitLogicalAggregate(LogicalAggregate<? extends Plan> aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet<Expression> childPredicates = aggregate.child().accept(this, context);
- // TODO
List<NamedExpression> outputExpressions = aggregate.getOutputExpressions();
-
- Map<Expression, Slot> expressionSlotMap
- = Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+ Map<Expression, List<Slot>> expressionSlotMap
+ = Maps.newHashMapWithExpectedSize(outputExpressions.size());
Review Comment:
not need to keep order anymore?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -273,24 +284,31 @@ public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Pla
public ImmutableSet<Expression> visitLogicalAggregate(LogicalAggregate<? extends Plan> aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet<Expression> childPredicates = aggregate.child().accept(this, context);
- // TODO
List<NamedExpression> outputExpressions = aggregate.getOutputExpressions();
-
- Map<Expression, Slot> expressionSlotMap
- = Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+ Map<Expression, List<Slot>> expressionSlotMap
+ = Maps.newHashMapWithExpectedSize(outputExpressions.size());
for (NamedExpression output : outputExpressions) {
- if (hasAgg(output)) {
- expressionSlotMap.putIfAbsent(
- output instanceof Alias ? output.child(0) : output, output.toSlot()
- );
+ if (output instanceof Alias && supportPullUpAgg(output.child(0))) {
+ expressionSlotMap.computeIfAbsent(output.child(0).child(0),
+ k -> new ArrayList<>()).add(output.toSlot());
+ }
Review Comment:
maybe need add some comment to explain when `supportPullUpAgg` return true, `output.child(0)` always has one child
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -68,9 +77,11 @@ public class PullUpPredicates extends PlanVisitor<ImmutableSet<Expression>, Void
Map<Plan, ImmutableSet<Expression>> cache = new IdentityHashMap<>();
private final boolean getAllPredicates;
+ private final ExpressionRewriteContext rewriteContext;
Review Comment:
could we add more detail about this rule in the class' comment or in each function's comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2636319445
<details>
<summary>TPC-DS: <b>Total hot run time: 185869 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false
query1 972 370 359 359
query2 6514 2088 2094 2088
query3 6801 210 215 210
query4 33618 23335 23555 23335
query5 4345 640 476 476
query6 302 195 181 181
query7 4599 481 307 307
query8 290 257 233 233
query9 9598 2702 2694 2694
query10 456 322 259 259
query11 17916 15456 15060 15060
query12 156 109 108 108
query13 1661 530 417 417
query14 10275 6968 6751 6751
query15 225 194 195 194
query16 8021 658 499 499
query17 1618 746 613 613
query18 2101 388 283 283
query19 224 183 154 154
query20 117 113 111 111
query21 213 121 100 100
query22 4184 4202 4134 4134
query23 34131 33176 33147 33147
query24 6802 2238 2248 2238
query25 490 458 379 379
query26 1215 270 152 152
query27 2041 458 339 339
query28 5475 2452 2443 2443
query29 701 530 417 417
query30 231 182 153 153
query31 959 875 805 805
query32 108 64 58 58
query33 517 344 295 295
query34 740 837 524 524
query35 800 821 729 729
query36 990 1052 939 939
query37 114 99 87 87
query38 4248 4158 4064 4064
query39 1457 1394 1395 1394
query40 207 115 99 99
query41 51 53 51 51
query42 120 100 102 100
query43 531 509 489 489
query44 1343 792 793 792
query45 186 178 166 166
query46 856 1041 645 645
query47 1823 1824 1770 1770
query48 384 395 329 329
query49 765 486 393 393
query50 624 695 404 404
query51 4223 4155 4131 4131
query52 107 111 93 93
query53 227 254 188 188
query54 475 500 434 434
query55 87 78 81 78
query56 269 261 233 233
query57 1112 1129 1078 1078
query58 250 237 237 237
query59 3054 3238 2930 2930
query60 280 266 257 257
query61 125 125 115 115
query62 815 734 648 648
query63 221 191 187 187
query64 4403 1050 654 654
query65 3233 3164 3119 3119
query66 1054 419 304 304
query67 15889 15496 15283 15283
query68 2433 829 568 568
query69 439 290 260 260
query70 1247 1154 1134 1134
query71 408 279 251 251
query72 5860 3813 3780 3780
query73 646 751 366 366
query74 10053 9179 8838 8838
query75 3171 3169 2654 2654
query76 2863 1227 803 803
query77 451 366 274 274
query78 10022 10370 9742 9742
query79 1022 888 593 593
query80 1280 539 470 470
query81 552 279 238 238
query82 364 154 124 124
query83 274 174 164 164
query84 235 95 70 70
query85 770 413 383 383
query86 411 319 314 314
query87 4465 4451 4517 4451
query88 3671 2244 2199 2199
query89 391 330 295 295
query90 1738 192 195 192
query91 202 141 106 106
query92 62 61 53 53
query93 955 877 548 548
query94 673 394 295 295
query95 336 269 259 259
query96 487 598 285 285
query97 2808 2871 2767 2767
query98 220 203 200 200
query99 1272 1399 1257 1257
Total cold run time: 277720 ms
Total hot run time: 185869 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1963717798
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -273,24 +284,31 @@ public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Pla
public ImmutableSet<Expression> visitLogicalAggregate(LogicalAggregate<? extends Plan> aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet<Expression> childPredicates = aggregate.child().accept(this, context);
- // TODO
List<NamedExpression> outputExpressions = aggregate.getOutputExpressions();
-
- Map<Expression, Slot> expressionSlotMap
- = Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+ Map<Expression, List<Slot>> expressionSlotMap
+ = Maps.newHashMapWithExpectedSize(outputExpressions.size());
Review Comment:
no need here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2432194653
<details>
<summary>TPC-H: <b>Total hot run time: 41601 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false
------ Round 1 ----------------------------------
q1 17597 7470 7304 7304
q2 2067 169 166 166
q3 10564 1170 1188 1170
q4 10230 819 832 819
q5 7743 3093 3118 3093
q6 238 151 152 151
q7 1040 621 602 602
q8 9354 1944 1955 1944
q9 6676 6459 6476 6459
q10 7114 2438 2450 2438
q11 457 253 253 253
q12 585 226 230 226
q13 17783 3031 3038 3031
q14 250 215 218 215
q15 571 524 509 509
q16 655 595 594 594
q17 994 530 545 530
q18 7399 6889 6860 6860
q19 1375 990 1036 990
q20 469 191 185 185
q21 4175 3357 3081 3081
q22 1122 1014 981 981
Total cold run time: 108458 ms
Total hot run time: 41601 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7302 7426 7277 7277
q2 328 231 234 231
q3 2960 2800 2817 2800
q4 1975 1700 1701 1700
q5 5479 5484 5526 5484
q6 233 149 148 148
q7 2161 1724 1761 1724
q8 3227 3410 3402 3402
q9 8543 8615 8631 8615
q10 3514 3509 3473 3473
q11 573 479 489 479
q12 804 583 600 583
q13 12541 3007 3046 3007
q14 301 265 264 264
q15 565 509 510 509
q16 687 635 643 635
q17 1840 1622 1569 1569
q18 7864 7541 7626 7541
q19 1666 1529 1492 1492
q20 2045 1819 1817 1817
q21 5413 5204 5273 5204
q22 1125 1021 1008 1008
Total cold run time: 71146 ms
Total hot run time: 58962 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2448925407
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2446949317
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919409102
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2803706750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #42199:
URL: https://github.com/apache/doris/pull/42199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2900999371
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723310174
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2606251555
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2432125148
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2426098755
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2426277680
<details>
<summary>TPC-DS: <b>Total hot run time: 191978 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false
query1 922 384 401 384
query2 6267 2132 2114 2114
query3 8705 193 211 193
query4 34205 23724 23466 23466
query5 3543 476 465 465
query6 281 180 172 172
query7 4192 295 293 293
query8 301 244 228 228
query9 9605 2731 2741 2731
query10 459 269 280 269
query11 17809 15199 15152 15152
query12 146 106 99 99
query13 1574 433 406 406
query14 9727 7489 7190 7190
query15 251 175 176 175
query16 7284 461 444 444
query17 1632 648 593 593
query18 1528 315 337 315
query19 376 156 178 156
query20 132 121 120 120
query21 209 108 107 107
query22 4781 4724 4657 4657
query23 35135 34182 34160 34160
query24 10870 2810 2732 2732
query25 616 434 396 396
query26 1142 161 164 161
query27 2202 286 293 286
query28 7364 2463 2436 2436
query29 716 435 436 435
query30 293 155 162 155
query31 1089 807 833 807
query32 97 57 54 54
query33 748 293 304 293
query34 914 534 489 489
query35 899 738 752 738
query36 1125 972 969 969
query37 148 88 89 88
query38 4143 3908 4028 3908
query39 1470 1437 1408 1408
query40 214 97 98 97
query41 48 47 46 46
query42 122 102 100 100
query43 543 514 492 492
query44 1266 812 810 810
query45 202 165 168 165
query46 1142 698 708 698
query47 1959 1864 1885 1864
query48 433 315 322 315
query49 1002 441 431 431
query50 813 391 394 391
query51 7100 6966 6973 6966
query52 104 94 93 93
query53 269 180 180 180
query54 1199 450 435 435
query55 78 74 76 74
query56 259 255 245 245
query57 1290 1209 1154 1154
query58 230 230 235 230
query59 3212 3238 3051 3051
query60 286 267 259 259
query61 106 103 103 103
query62 863 656 653 653
query63 222 188 187 187
query64 4014 634 603 603
query65 3266 3230 3226 3226
query66 823 302 337 302
query67 16133 15617 15741 15617
query68 3514 582 568 568
query69 506 297 294 294
query70 1222 1061 1060 1060
query71 345 279 298 279
query72 7292 3976 3831 3831
query73 775 354 378 354
query74 10123 9223 8944 8944
query75 3460 2643 2632 2632
query76 2963 917 922 917
query77 614 311 298 298
query78 10451 9640 9558 9558
query79 2010 588 603 588
query80 1049 451 445 445
query81 584 241 241 241
query82 649 136 139 136
query83 276 134 132 132
query84 272 68 70 68
query85 1309 299 294 294
query86 414 284 301 284
query87 4518 4421 4291 4291
query88 3052 2230 2190 2190
query89 407 287 294 287
query90 1947 184 189 184
query91 134 103 101 101
query92 62 50 48 48
query93 1795 537 538 537
query94 933 292 292 292
query95 349 246 249 246
query96 620 274 291 274
query97 3282 3107 3090 3090
query98 217 198 192 192
query99 1586 1329 1292 1292
Total cold run time: 296828 ms
Total hot run time: 191978 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919862814
<details>
<summary>ClickBench: <b>Total hot run time: 28.71 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21ad56da2abc20ff3f55cae77e2bf8cafa70d4ba, data reload: false
query1 0.03 0.04 0.03
query2 0.12 0.11 0.11
query3 0.26 0.19 0.20
query4 1.59 0.20 0.20
query5 0.46 0.44 0.45
query6 1.17 0.67 0.66
query7 0.03 0.01 0.02
query8 0.05 0.04 0.03
query9 0.58 0.51 0.53
query10 0.58 0.57 0.58
query11 0.15 0.11 0.11
query12 0.15 0.11 0.11
query13 0.61 0.60 0.60
query14 0.78 0.83 0.81
query15 0.87 0.85 0.86
query16 0.38 0.38 0.36
query17 1.00 1.03 1.06
query18 0.23 0.21 0.21
query19 1.94 1.80 1.88
query20 0.02 0.01 0.02
query21 15.40 0.89 0.53
query22 0.75 1.27 0.65
query23 14.95 1.37 0.62
query24 7.68 0.75 0.61
query25 0.48 0.20 0.07
query26 0.55 0.17 0.13
query27 0.06 0.05 0.04
query28 9.49 0.95 0.43
query29 12.62 4.01 3.25
query30 0.25 0.09 0.07
query31 2.82 0.60 0.39
query32 3.24 0.56 0.47
query33 3.03 3.07 3.04
query34 15.70 5.13 4.49
query35 4.51 4.53 4.49
query36 0.68 0.49 0.49
query37 0.08 0.06 0.07
query38 0.06 0.04 0.04
query39 0.03 0.02 0.02
query40 0.15 0.13 0.12
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.02
Total cold run time: 103.68 s
Total hot run time: 28.71 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2900690481
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2938277155
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "924060929 (via GitHub)" <gi...@apache.org>.
924060929 commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r1994634619
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -325,8 +343,8 @@ private ImmutableSet<Expression> getAvailableExpressions(Set<Expression> predica
return ImmutableSet.copyOf(newPredicates);
}
- private boolean hasAgg(Expression expression) {
- return expression.anyMatch(AggregateFunction.class::isInstance);
+ private boolean supportPullUpAgg(Expression expr) {
Review Comment:
origin logic seems trivial, or not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2900783320
<details>
<summary>TPC-DS: <b>Total hot run time: 186481 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b0b16ad101792258253d8356d2b35a511bbfef5b, data reload: false
query1 1019 490 494 490
query2 6567 1846 1833 1833
query3 6756 227 223 223
query4 26294 23981 23067 23067
query5 4304 642 469 469
query6 301 214 196 196
query7 4614 515 283 283
query8 288 251 239 239
query9 8618 2615 2633 2615
query10 484 344 265 265
query11 15609 15152 14891 14891
query12 160 109 109 109
query13 1668 531 400 400
query14 9297 6330 6361 6330
query15 215 189 167 167
query16 7185 619 464 464
query17 1211 700 554 554
query18 1970 393 290 290
query19 182 190 158 158
query20 122 112 120 112
query21 211 128 108 108
query22 3992 4149 3955 3955
query23 33971 33083 33032 33032
query24 8440 2458 2422 2422
query25 556 496 425 425
query26 1241 275 155 155
query27 2767 517 354 354
query28 4355 2146 2136 2136
query29 796 601 471 471
query30 293 216 188 188
query31 969 876 789 789
query32 79 70 69 69
query33 563 403 327 327
query34 830 861 534 534
query35 799 828 735 735
query36 961 985 894 894
query37 119 108 86 86
query38 4223 4082 4058 4058
query39 1472 1415 1480 1415
query40 223 134 121 121
query41 68 63 60 60
query42 130 118 118 118
query43 512 530 507 507
query44 1381 839 824 824
query45 233 173 165 165
query46 875 1048 641 641
query47 1750 1827 1719 1719
query48 389 420 314 314
query49 773 517 435 435
query50 692 705 425 425
query51 4132 4104 4109 4104
query52 115 109 99 99
query53 233 262 192 192
query54 590 580 502 502
query55 94 83 81 81
query56 293 309 280 280
query57 1110 1123 1091 1091
query58 263 264 259 259
query59 2603 2655 2588 2588
query60 325 329 319 319
query61 133 127 125 125
query62 805 731 673 673
query63 238 195 189 189
query64 4419 1012 685 685
query65 4349 4251 4249 4249
query66 1142 417 310 310
query67 15889 15815 15515 15515
query68 8470 906 528 528
query69 476 318 280 280
query70 1226 1149 1078 1078
query71 474 338 303 303
query72 5550 4770 4578 4578
query73 727 620 359 359
query74 9265 9076 9001 9001
query75 3979 3246 2715 2715
query76 3674 1224 775 775
query77 788 390 297 297
query78 10040 10153 9382 9382
query79 6750 841 577 577
query80 658 543 454 454
query81 474 259 229 229
query82 721 130 101 101
query83 299 260 236 236
query84 299 111 93 93
query85 805 355 319 319
query86 337 312 296 296
query87 4431 4496 4324 4324
query88 3416 2279 2279 2279
query89 458 330 295 295
query90 1935 215 218 215
query91 147 159 116 116
query92 83 63 57 57
query93 3347 965 586 586
query94 678 409 302 302
query95 380 319 291 291
query96 505 589 291 291
query97 2725 2713 2657 2657
query98 228 213 202 202
query99 1444 1384 1367 1367
Total cold run time: 282049 ms
Total hot run time: 186481 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2900751969
<details>
<summary>TPC-H: <b>Total hot run time: 33821 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b0b16ad101792258253d8356d2b35a511bbfef5b, data reload: false
------ Round 1 ----------------------------------
q1 26471 5295 5066 5066
q2 2082 283 198 198
q3 10585 1266 694 694
q4 10267 1047 519 519
q5 8347 2339 2391 2339
q6 181 162 132 132
q7 936 786 603 603
q8 9311 1263 1126 1126
q9 6826 5099 5082 5082
q10 6822 2323 1888 1888
q11 487 288 279 279
q12 354 355 218 218
q13 17769 3691 3137 3137
q14 227 237 221 221
q15 545 501 485 485
q16 425 430 372 372
q17 617 870 365 365
q18 7769 7334 6998 6998
q19 1362 963 548 548
q20 336 349 224 224
q21 3658 3137 2352 2352
q22 1063 1019 975 975
Total cold run time: 116440 ms
Total hot run time: 33821 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5140 5113 5091 5091
q2 235 325 226 226
q3 2148 2672 2316 2316
q4 1375 1787 1505 1505
q5 4519 4430 4365 4365
q6 220 169 128 128
q7 2008 1878 1753 1753
q8 2595 2620 2532 2532
q9 7136 7085 7167 7085
q10 3027 3171 2731 2731
q11 578 508 484 484
q12 699 784 617 617
q13 3503 3966 3323 3323
q14 300 297 271 271
q15 516 466 471 466
q16 428 477 429 429
q17 1138 1528 1401 1401
q18 7753 7546 7386 7386
q19 814 822 823 822
q20 1984 2034 1952 1952
q21 4728 4275 4245 4245
q22 1057 1008 1003 1003
Total cold run time: 51901 ms
Total hot run time: 50131 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2901100025
<details>
<summary>TPC-DS: <b>Total hot run time: 184716 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 864d403a4b52b10fbe491c24bc8a625494db2584, data reload: false
query1 999 469 490 469
query2 6560 1896 1826 1826
query3 6738 229 218 218
query4 26080 23723 23071 23071
query5 4377 614 449 449
query6 298 198 204 198
query7 4618 505 289 289
query8 302 253 251 251
query9 8603 2644 2605 2605
query10 487 364 264 264
query11 15574 14940 14793 14793
query12 157 102 106 102
query13 1629 521 408 408
query14 8631 6158 5991 5991
query15 195 189 165 165
query16 7113 621 468 468
query17 908 696 556 556
query18 1965 391 312 312
query19 189 188 157 157
query20 138 116 122 116
query21 209 124 108 108
query22 4084 4120 4070 4070
query23 33974 33143 32806 32806
query24 8394 2353 2333 2333
query25 551 456 445 445
query26 1235 263 147 147
query27 2749 490 328 328
query28 4364 2141 2119 2119
query29 763 545 423 423
query30 278 221 191 191
query31 931 871 748 748
query32 72 63 60 60
query33 566 353 319 319
query34 783 834 534 534
query35 769 809 728 728
query36 959 1002 876 876
query37 111 102 83 83
query38 4116 4131 4059 4059
query39 1474 1396 1397 1396
query40 212 120 109 109
query41 56 54 52 52
query42 117 111 108 108
query43 515 507 486 486
query44 1290 819 805 805
query45 181 183 168 168
query46 820 1014 637 637
query47 1772 1823 1722 1722
query48 388 429 312 312
query49 778 525 452 452
query50 644 674 416 416
query51 4143 4107 4061 4061
query52 112 109 99 99
query53 222 253 182 182
query54 617 568 514 514
query55 82 83 87 83
query56 318 302 297 297
query57 1140 1155 1083 1083
query58 273 259 268 259
query59 2630 2679 2474 2474
query60 341 331 327 327
query61 147 147 141 141
query62 803 728 659 659
query63 217 188 221 188
query64 4313 987 668 668
query65 4325 4219 4228 4219
query66 1150 413 317 317
query67 15976 15668 15393 15393
query68 8405 881 519 519
query69 494 305 262 262
query70 1228 1088 1102 1088
query71 451 316 297 297
query72 5698 4708 4795 4708
query73 728 641 353 353
query74 8810 9138 8605 8605
query75 3903 3209 2683 2683
query76 3663 1186 753 753
query77 796 381 288 288
query78 9964 10146 9395 9395
query79 2279 815 584 584
query80 620 523 429 429
query81 466 259 217 217
query82 415 129 93 93
query83 283 245 228 228
query84 293 95 85 85
query85 823 348 313 313
query86 339 319 275 275
query87 4456 4474 4347 4347
query88 3144 2261 2306 2261
query89 374 320 279 279
query90 1934 208 208 208
query91 138 167 111 111
query92 77 56 55 55
query93 1532 949 577 577
query94 671 401 293 293
query95 371 287 281 281
query96 492 572 282 282
query97 2717 2739 2677 2677
query98 229 210 205 205
query99 1418 1424 1253 1253
Total cold run time: 272736 ms
Total hot run time: 184716 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2636231939
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2636331688
<details>
<summary>ClickBench: <b>Total hot run time: 30.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d9beba2bbe5801c8d2ad396c173c4ca974342eac, data reload: false
query1 0.04 0.03 0.03
query2 0.06 0.04 0.03
query3 0.25 0.07 0.06
query4 1.62 0.10 0.11
query5 0.44 0.42 0.41
query6 1.15 0.65 0.66
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.49 0.51
query10 0.56 0.57 0.56
query11 0.16 0.09 0.09
query12 0.14 0.12 0.12
query13 0.62 0.59 0.59
query14 2.86 2.89 2.87
query15 0.88 0.82 0.84
query16 0.38 0.36 0.37
query17 0.99 1.01 0.98
query18 0.23 0.22 0.21
query19 1.91 2.00 1.87
query20 0.02 0.01 0.01
query21 15.39 0.93 0.58
query22 0.73 0.80 0.83
query23 15.11 1.48 0.56
query24 2.89 1.20 0.83
query25 0.19 0.22 0.06
query26 0.25 0.15 0.14
query27 0.08 0.06 0.04
query28 13.82 1.09 0.45
query29 12.57 3.93 3.24
query30 0.25 0.08 0.06
query31 2.82 0.59 0.38
query32 3.22 0.54 0.48
query33 2.95 3.09 3.03
query34 16.64 5.14 4.54
query35 4.49 4.47 4.55
query36 0.66 0.51 0.50
query37 0.09 0.06 0.06
query38 0.05 0.04 0.03
query39 0.03 0.03 0.02
query40 0.17 0.14 0.14
query41 0.08 0.02 0.02
query42 0.04 0.02 0.02
query43 0.03 0.02 0.02
Total cold run time: 105.5 s
Total hot run time: 30.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2499671177
<details>
<summary>ClickBench: <b>Total hot run time: 33.25 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ecdd0726355ea639e978a478e6bafab23087a721, data reload: false
query1 0.04 0.04 0.04
query2 0.06 0.04 0.03
query3 0.23 0.08 0.07
query4 1.61 0.10 0.11
query5 0.42 0.42 0.40
query6 1.14 0.65 0.67
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.57 0.49 0.51
query10 0.53 0.58 0.56
query11 0.14 0.10 0.11
query12 0.14 0.11 0.11
query13 0.61 0.61 0.61
query14 2.71 2.72 2.72
query15 0.91 0.83 0.84
query16 0.38 0.39 0.38
query17 1.00 1.07 1.03
query18 0.24 0.21 0.21
query19 1.96 1.85 1.93
query20 0.02 0.01 0.01
query21 15.37 0.59 0.58
query22 2.73 1.96 2.44
query23 16.88 0.96 0.84
query24 2.63 1.28 1.78
query25 0.15 0.24 0.16
query26 0.42 0.14 0.13
query27 0.05 0.06 0.04
query28 10.42 1.10 1.09
query29 12.52 3.25 3.21
query30 0.25 0.06 0.07
query31 2.86 0.39 0.38
query32 3.28 0.46 0.47
query33 3.03 3.11 3.03
query34 16.86 4.53 4.55
query35 4.57 4.47 4.54
query36 0.66 0.50 0.49
query37 0.09 0.06 0.07
query38 0.05 0.04 0.03
query39 0.03 0.02 0.03
query40 0.16 0.13 0.13
query41 0.07 0.02 0.02
query42 0.04 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 105.93 s
Total hot run time: 33.25 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2919801802
<details>
<summary>TPC-H: <b>Total hot run time: 33710 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21ad56da2abc20ff3f55cae77e2bf8cafa70d4ba, data reload: false
------ Round 1 ----------------------------------
q1 25920 5044 4966 4966
q2 1963 278 184 184
q3 10490 1252 677 677
q4 10251 1014 553 553
q5 7950 2354 2338 2338
q6 189 168 129 129
q7 931 717 596 596
q8 9301 1296 1115 1115
q9 6772 5064 5112 5064
q10 6881 2339 1882 1882
q11 499 281 267 267
q12 337 352 211 211
q13 17761 3669 3062 3062
q14 238 223 214 214
q15 557 489 481 481
q16 420 427 377 377
q17 587 849 353 353
q18 7866 7206 7304 7206
q19 1754 974 537 537
q20 331 336 225 225
q21 3751 2520 2327 2327
q22 1049 1014 946 946
Total cold run time: 115798 ms
Total hot run time: 33710 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5146 5014 5076 5014
q2 231 316 224 224
q3 2176 2671 2321 2321
q4 1316 1764 1384 1384
q5 4376 4320 4460 4320
q6 217 169 128 128
q7 1985 1895 1763 1763
q8 2566 2665 2535 2535
q9 7306 7180 6948 6948
q10 3048 3205 2728 2728
q11 590 505 496 496
q12 676 743 600 600
q13 3492 3882 3299 3299
q14 288 304 290 290
q15 529 485 490 485
q16 425 487 439 439
q17 1140 1520 1387 1387
q18 7854 7472 7393 7393
q19 789 843 976 843
q20 2022 1976 1827 1827
q21 4765 4443 4316 4316
q22 1073 1088 1019 1019
Total cold run time: 52010 ms
Total hot run time: 49759 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2911055641
<details>
<summary>TPC-H: <b>Total hot run time: 33692 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 885d3702646692487d57203f3934d473cdec56ec, data reload: false
------ Round 1 ----------------------------------
q1 26226 5060 5043 5043
q2 2081 279 186 186
q3 10516 1239 686 686
q4 10235 1004 520 520
q5 7667 2388 2317 2317
q6 187 165 130 130
q7 915 733 594 594
q8 9312 1286 1052 1052
q9 6831 5120 5109 5109
q10 6857 2318 1908 1908
q11 495 281 306 281
q12 341 351 212 212
q13 17787 3673 3068 3068
q14 217 225 210 210
q15 536 492 495 492
q16 419 435 391 391
q17 607 863 370 370
q18 7556 7123 7007 7007
q19 2047 995 566 566
q20 333 330 222 222
q21 3676 3136 2343 2343
q22 1010 1003 985 985
Total cold run time: 115851 ms
Total hot run time: 33692 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5258 5111 5100 5100
q2 233 323 228 228
q3 2159 2642 2267 2267
q4 1342 1752 1352 1352
q5 4480 4376 4430 4376
q6 217 169 134 134
q7 2038 1945 1782 1782
q8 2713 2484 2660 2484
q9 7234 7267 6861 6861
q10 3042 3189 2772 2772
q11 579 517 498 498
q12 655 758 600 600
q13 3500 3958 3257 3257
q14 295 314 288 288
q15 529 496 490 490
q16 463 484 455 455
q17 1175 1574 1358 1358
q18 7842 7612 7363 7363
q19 814 783 932 783
q20 1985 2038 1826 1826
q21 4831 4581 4390 4390
q22 1084 1054 996 996
Total cold run time: 52468 ms
Total hot run time: 49660 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #42199:
URL: https://github.com/apache/doris/pull/42199#discussion_r2108620634
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/InferPredicatesTest.java:
##########
@@ -140,62 +142,66 @@ void inferPredicatesTest04() {
.rewrite()
.matches(
logicalJoin(
- logicalFilter(logicalOlapScan()).when(filter -> !ExpressionUtils.isInferred(filter.getPredicate())
- & filter.getPredicate().toSql().contains("id IN (1, 2, 3)")),
- logicalFilter(logicalOlapScan()).when(filter -> ExpressionUtils.isInferred(filter.getPredicate())
- & filter.getPredicate().toSql().contains("sid IN (1, 2, 3)"))
+ logicalFilter(logicalOlapScan()).when(
+ filter -> !ExpressionUtils.isInferred(filter.getPredicate())
+ & filter.getPredicate().toSql().contains("id IN (1, 2, 3)")),
+ logicalFilter(logicalOlapScan()).when(
+ filter -> ExpressionUtils.isInferred(filter.getPredicate())
+ & filter.getPredicate().toSql().contains("sid IN (1, 2, 3)"))
)
);
}
@Test
void inferPredicatesTest05() {
- String sql = "select * from student join score on student.id = score.sid join course on score.sid = course.id where student.id > 1";
+ String sql
Review Comment:
[nitpick] Splitting the SQL string assignment across multiple lines reduces readability. Consider using Java text blocks (`"""..."""`) for multiline SQL or keep the entire statement on one line.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -253,8 +264,13 @@ public ImmutableSet<Expression> visitLogicalJoin(LogicalJoin<? extends Plan, ? e
public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Plan> project, Void context) {
return cacheOrElse(project, () -> {
ImmutableSet<Expression> childPredicates = project.child().accept(this, context);
- Set<Expression> allPredicates = Sets.newLinkedHashSet(childPredicates);
- for (Entry<Slot, Expression> kv : project.getAliasToProducer().entrySet()) {
+ Set<Expression> allPredicates = Sets.newLinkedHashSet();
Review Comment:
When `getAllPredicates` is false, the original `childPredicates` are never added, so any predicates not matching an alias replacement are dropped. Consider initializing `allPredicates` with `childPredicates` or selectively adding predicates that reference directly projected slots.
```suggestion
Set<Expression> allPredicates = Sets.newLinkedHashSet(childPredicates);
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -270,28 +286,40 @@ public ImmutableSet<Expression> visitLogicalProject(LogicalProject<? extends Pla
});
}
+ /* e.g. LogicalAggregate(output:max(a), min(a), avg(a))
+ +--LogicalFilter(a>1, a<10)
+ when a>1 is pulled up, we can have max(a)>1, min(a)>1 and avg(a)>1
+ and a<10 is pulled up, we can have max(a)<10, min(a)<10 and avg(a)<10
+ * */
@Override
public ImmutableSet<Expression> visitLogicalAggregate(LogicalAggregate<? extends Plan> aggregate, Void context) {
return cacheOrElse(aggregate, () -> {
ImmutableSet<Expression> childPredicates = aggregate.child().accept(this, context);
- // TODO
List<NamedExpression> outputExpressions = aggregate.getOutputExpressions();
-
- Map<Expression, Slot> expressionSlotMap
- = Maps.newLinkedHashMapWithExpectedSize(outputExpressions.size());
+ Map<Expression, List<Slot>> expressionSlotMap
+ = Maps.newHashMapWithExpectedSize(outputExpressions.size());
for (NamedExpression output : outputExpressions) {
- if (hasAgg(output)) {
- expressionSlotMap.putIfAbsent(
- output instanceof Alias ? output.child(0) : output, output.toSlot()
- );
+ if (output instanceof Alias && supportPullUpAgg(output.child(0))) {
+ expressionSlotMap.computeIfAbsent(output.child(0).child(0),
+ k -> new ArrayList<>()).add(output.toSlot());
+ }
+ }
+ Set<Expression> pullPredicates = new LinkedHashSet<>(childPredicates);
+ for (Expression childPredicate : childPredicates) {
+ if (childPredicate instanceof ComparisonPredicate) {
+ ComparisonPredicate cmp = (ComparisonPredicate) childPredicate;
+ if (cmp.left() instanceof SlotReference && cmp.right() instanceof Literal
Review Comment:
The code only handles comparison predicates with slot on the left and literal on the right. Predicates like `literal < slot` won’t be inferred. Consider detecting both operand orders or normalizing predicate direction before inference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723302807
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2723395254
<details>
<summary>TPC-DS: <b>Total hot run time: 192050 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b5432b73fb9b4588b919dc85dc8f74eb1dca2cb7, data reload: false
query1 1421 1001 1004 1001
query2 6427 1919 1869 1869
query3 11142 4579 4690 4579
query4 26051 23921 23157 23157
query5 4716 669 468 468
query6 303 210 187 187
query7 3990 511 287 287
query8 291 247 236 236
query9 8506 2608 2597 2597
query10 488 316 259 259
query11 15453 15075 14894 14894
query12 179 115 111 111
query13 1586 517 398 398
query14 9692 6301 6939 6301
query15 220 190 177 177
query16 7650 681 512 512
query17 1528 810 626 626
query18 2052 474 335 335
query19 236 205 163 163
query20 133 128 121 121
query21 217 128 101 101
query22 4429 4577 4644 4577
query23 34433 33611 33616 33611
query24 7180 2398 2424 2398
query25 490 464 391 391
query26 838 278 157 157
query27 2379 490 327 327
query28 4346 2442 2432 2432
query29 632 560 418 418
query30 274 219 198 198
query31 924 872 847 847
query32 73 63 61 61
query33 539 369 299 299
query34 806 902 511 511
query35 816 852 779 779
query36 965 1002 913 913
query37 114 96 78 78
query38 4248 4248 4108 4108
query39 1519 1454 1436 1436
query40 206 116 100 100
query41 51 48 50 48
query42 119 108 109 108
query43 510 512 473 473
query44 1314 783 783 783
query45 186 185 170 170
query46 861 1028 643 643
query47 1853 1885 1832 1832
query48 403 420 312 312
query49 717 510 417 417
query50 706 743 413 413
query51 4320 4353 4270 4270
query52 108 102 98 98
query53 241 268 191 191
query54 521 508 420 420
query55 93 88 78 78
query56 294 272 248 248
query57 1182 1181 1135 1135
query58 270 253 241 241
query59 2687 2792 2735 2735
query60 285 283 269 269
query61 122 115 120 115
query62 846 727 673 673
query63 236 190 195 190
query64 3307 1039 687 687
query65 4649 4449 4450 4449
query66 925 416 303 303
query67 16491 15577 15364 15364
query68 9554 886 497 497
query69 476 297 264 264
query70 1217 1146 1093 1093
query71 464 294 262 262
query72 5147 3678 3906 3678
query73 827 747 354 354
query74 9043 9114 8645 8645
query75 4363 3154 2724 2724
query76 5076 1202 752 752
query77 986 350 270 270
query78 9917 10233 9319 9319
query79 3007 825 565 565
query80 591 516 446 446
query81 465 263 217 217
query82 229 125 94 94
query83 161 169 149 149
query84 287 91 76 76
query85 744 360 351 351
query86 329 311 301 301
query87 4595 4564 4302 4302
query88 2883 2217 2294 2217
query89 426 317 273 273
query90 2184 209 215 209
query91 139 140 107 107
query92 70 57 53 53
query93 2274 1034 566 566
query94 673 408 306 306
query95 349 259 257 257
query96 483 545 278 278
query97 3327 3438 3289 3289
query98 216 204 205 204
query99 1385 1406 1247 1247
Total cold run time: 282676 ms
Total hot run time: 192050 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2803750080
<details>
<summary>TPC-DS: <b>Total hot run time: 186433 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d131b92e19dabb9652588d7253de5ad3077f2b9b, data reload: false
query1 1017 494 510 494
query2 6545 1903 1918 1903
query3 6762 231 216 216
query4 25941 23794 23338 23338
query5 4382 628 463 463
query6 310 205 199 199
query7 4621 492 290 290
query8 299 254 246 246
query9 8626 2573 2597 2573
query10 502 331 269 269
query11 15821 15038 15323 15038
query12 170 112 106 106
query13 1665 515 401 401
query14 9614 6152 6101 6101
query15 220 185 173 173
query16 7392 651 478 478
query17 1225 741 580 580
query18 1980 407 308 308
query19 205 197 172 172
query20 122 115 118 115
query21 214 123 111 111
query22 4184 4147 3989 3989
query23 34071 33033 33225 33033
query24 8408 2350 2376 2350
query25 510 438 391 391
query26 1234 305 153 153
query27 2700 503 330 330
query28 4368 2393 2414 2393
query29 719 557 426 426
query30 289 223 187 187
query31 939 866 764 764
query32 74 90 65 65
query33 555 383 301 301
query34 788 873 507 507
query35 808 813 743 743
query36 978 998 900 900
query37 124 98 79 79
query38 4246 4085 4122 4085
query39 1451 1404 1382 1382
query40 207 122 106 106
query41 58 53 52 52
query42 123 107 106 106
query43 513 505 497 497
query44 1318 799 813 799
query45 187 176 167 167
query46 839 1023 623 623
query47 1733 1800 1717 1717
query48 384 410 302 302
query49 778 495 439 439
query50 633 670 383 383
query51 4167 4165 4062 4062
query52 106 111 103 103
query53 222 257 184 184
query54 575 574 498 498
query55 87 85 82 82
query56 316 313 294 294
query57 1156 1135 1070 1070
query58 268 263 279 263
query59 2667 2649 2511 2511
query60 326 310 296 296
query61 128 124 124 124
query62 794 710 654 654
query63 218 182 187 182
query64 4308 1014 662 662
query65 4357 4217 4264 4217
query66 1149 423 309 309
query67 15761 15824 15356 15356
query68 8196 895 513 513
query69 465 299 255 255
query70 1212 1119 1130 1119
query71 482 324 285 285
query72 5543 4759 4907 4759
query73 697 606 342 342
query74 8886 8978 8974 8974
query75 3898 3204 2680 2680
query76 3728 1182 744 744
query77 791 392 298 298
query78 10094 10280 9196 9196
query79 1689 812 552 552
query80 604 523 430 430
query81 467 272 225 225
query82 454 130 101 101
query83 258 253 233 233
query84 245 113 89 89
query85 778 411 308 308
query86 336 295 280 280
query87 4455 4395 4395 4395
query88 2854 2207 2197 2197
query89 387 313 278 278
query90 1939 213 207 207
query91 139 141 111 111
query92 77 62 57 57
query93 1057 941 576 576
query94 669 416 307 307
query95 380 287 278 278
query96 489 583 272 272
query97 3174 3317 3170 3170
query98 221 214 213 213
query99 1656 1398 1279 1279
Total cold run time: 273777 ms
Total hot run time: 186433 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2673864066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2674008960
<details>
<summary>ClickBench: <b>Total hot run time: 30.58 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 563407c27d31afaca36163575298fbe46d66912a, data reload: false
query1 0.04 0.02 0.03
query2 0.07 0.03 0.04
query3 0.24 0.07 0.07
query4 1.61 0.11 0.10
query5 0.42 0.41 0.39
query6 1.17 0.65 0.66
query7 0.02 0.01 0.02
query8 0.04 0.03 0.03
query9 0.60 0.51 0.52
query10 0.56 0.58 0.56
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.59 0.60
query14 2.74 2.70 2.70
query15 0.92 0.86 0.86
query16 0.36 0.38 0.37
query17 1.03 1.05 1.00
query18 0.20 0.20 0.19
query19 1.93 1.80 2.02
query20 0.01 0.01 0.01
query21 15.35 0.92 0.55
query22 0.76 1.26 0.60
query23 14.92 1.40 0.64
query24 7.12 2.35 0.81
query25 0.50 0.15 0.18
query26 0.71 0.16 0.13
query27 0.06 0.05 0.06
query28 9.66 0.82 0.43
query29 12.53 3.98 3.33
query30 0.24 0.08 0.06
query31 2.83 0.58 0.38
query32 3.22 0.54 0.47
query33 2.98 2.98 3.03
query34 15.95 5.13 4.56
query35 4.58 4.53 4.60
query36 0.65 0.51 0.48
query37 0.09 0.07 0.06
query38 0.05 0.05 0.04
query39 0.03 0.03 0.02
query40 0.17 0.13 0.12
query41 0.08 0.03 0.03
query42 0.04 0.03 0.02
query43 0.04 0.03 0.03
Total cold run time: 105.42 s
Total hot run time: 30.58 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2426288913
<details>
<summary>ClickBench: <b>Total hot run time: 32.26 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f003cfa34ac896360edc7152f6b5e51293237326, data reload: false
query1 0.04 0.04 0.03
query2 0.06 0.03 0.03
query3 0.23 0.06 0.06
query4 1.67 0.10 0.10
query5 0.52 0.49 0.50
query6 1.13 0.73 0.73
query7 0.02 0.03 0.01
query8 0.04 0.03 0.03
query9 0.56 0.51 0.49
query10 0.56 0.55 0.56
query11 0.16 0.12 0.11
query12 0.14 0.11 0.11
query13 0.61 0.59 0.60
query14 2.84 2.84 2.73
query15 0.90 0.83 0.84
query16 0.38 0.38 0.39
query17 1.06 1.07 0.99
query18 0.19 0.19 0.19
query19 1.93 1.87 2.05
query20 0.01 0.01 0.01
query21 15.36 0.61 0.56
query22 2.47 1.77 1.51
query23 17.14 0.96 0.76
query24 2.58 0.87 2.20
query25 0.20 0.18 0.10
query26 0.59 0.14 0.14
query27 0.04 0.04 0.04
query28 10.16 1.10 1.07
query29 12.55 3.25 3.27
query30 0.24 0.06 0.05
query31 2.89 0.39 0.36
query32 3.28 0.45 0.46
query33 3.02 3.08 3.05
query34 16.92 4.52 4.46
query35 4.51 4.49 4.54
query36 0.67 0.49 0.50
query37 0.09 0.05 0.06
query38 0.05 0.04 0.03
query39 0.04 0.02 0.02
query40 0.17 0.12 0.13
query41 0.08 0.03 0.02
query42 0.04 0.02 0.02
query43 0.04 0.02 0.02
Total cold run time: 106.18 s
Total hot run time: 32.26 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2432267537
<details>
<summary>ClickBench: <b>Total hot run time: 33.29 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 07b17d30d410bd73069d6b6b2ff1a7f70eb3aeff, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.02
query3 0.22 0.06 0.06
query4 1.65 0.10 0.10
query5 0.51 0.51 0.51
query6 1.13 0.73 0.72
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.56 0.50 0.51
query10 0.55 0.56 0.55
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.61 0.61 0.59
query14 2.83 2.75 2.71
query15 0.91 0.84 0.83
query16 0.40 0.38 0.37
query17 1.01 1.01 1.05
query18 0.20 0.20 0.20
query19 1.95 1.88 2.00
query20 0.01 0.01 0.01
query21 15.35 0.62 0.61
query22 3.12 2.68 2.40
query23 17.14 0.94 0.88
query24 3.31 0.88 0.90
query25 0.27 0.22 0.05
query26 0.44 0.14 0.13
query27 0.04 0.03 0.03
query28 10.63 1.10 1.07
query29 12.52 3.31 3.30
query30 0.24 0.07 0.06
query31 2.84 0.38 0.38
query32 3.26 0.47 0.46
query33 3.01 3.00 3.04
query34 17.17 4.46 4.53
query35 4.47 4.46 4.47
query36 0.68 0.48 0.49
query37 0.08 0.06 0.06
query38 0.05 0.03 0.03
query39 0.03 0.03 0.02
query40 0.16 0.12 0.13
query41 0.08 0.02 0.03
query42 0.04 0.02 0.02
query43 0.03 0.04 0.02
Total cold run time: 107.95 s
Total hot run time: 33.29 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feature](nereids) support pull up predicates from aggregate min/max/avg [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42199:
URL: https://github.com/apache/doris/pull/42199#issuecomment-2451304982
<details>
<summary>ClickBench: <b>Total hot run time: 33.03 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f1e405f3e40ba131d6e3e9c1f58b0067abdfc3c7, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.11 0.11
query5 0.42 0.42 0.42
query6 1.14 0.65 0.67
query7 0.01 0.02 0.01
query8 0.04 0.03 0.05
query9 0.56 0.51 0.51
query10 0.56 0.56 0.55
query11 0.14 0.10 0.10
query12 0.14 0.11 0.11
query13 0.61 0.61 0.61
query14 2.86 2.84 2.71
query15 0.89 0.83 0.82
query16 0.39 0.38 0.37
query17 1.08 1.07 1.06
query18 0.20 0.20 0.19
query19 1.98 1.90 2.02
query20 0.01 0.00 0.01
query21 15.39 0.59 0.58
query22 2.76 2.01 1.88
query23 17.03 0.92 0.82
query24 2.83 1.34 2.26
query25 0.16 0.18 0.05
query26 0.57 0.13 0.14
query27 0.04 0.04 0.04
query28 9.66 1.08 1.07
query29 12.58 3.27 3.25
query30 0.24 0.07 0.06
query31 2.86 0.39 0.37
query32 3.27 0.46 0.44
query33 2.96 3.05 3.06
query34 17.13 4.48 4.45
query35 4.52 4.50 4.45
query36 0.67 0.48 0.51
query37 0.08 0.06 0.06
query38 0.05 0.03 0.03
query39 0.03 0.02 0.02
query40 0.15 0.13 0.12
query41 0.09 0.02 0.02
query42 0.04 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 106.14 s
Total hot run time: 33.03 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org