You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/10/07 09:02:52 UTC

[GitHub] [struts] gregh3269 opened a new pull request, #610: Add missing classes and tld definition.

gregh3269 opened a new pull request, #610:
URL: https://github.com/apache/struts/pull/610

   Works great for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

[GitHub] [struts] coveralls commented on pull request #610: Add missing classes and tld definition.

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #610:
URL: https://github.com/apache/struts/pull/610#issuecomment-1271335631

   
   [![Coverage Status](https://coveralls.io/builds/53088484/badge)](https://coveralls.io/builds/53088484)
   
   Coverage decreased (-0.3%) to 51.819% when pulling **b3f1c1e6d267e4110176fe5617799b1b908a6abd on gregh3269:WW-5233-tiles** into **00a37236a6948d82c60ce120138ee7c11ef709e7 on apache:WW-5233-tiles**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] gregh3269 commented on pull request #610: Add missing classes and tld definition.

Posted by GitBox <gi...@apache.org>.
gregh3269 commented on PR #610:
URL: https://github.com/apache/struts/pull/610#issuecomment-1271346962

   Coveralls thingy
   
   GetAsStringTag
   from: private GetAsStringModel model = new GetAsStringModel());
   to: private GetAsStringModel model = new GetAsStringModel(new DefaultAttributeResolver());
   
   and then remove change:
   GetAsStringModel:
    /**
        * Constructor that uses the defaut attribute resolver.
        *
        * @since 3.0.0
        */
       public GetAsStringModel() {
           this(new DefaultAttributeResolver());
       }
   It does not say why it does not like the constructor?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [struts] lukaszlenart merged pull request #610: Add missing classes and tld definition.

Posted by GitBox <gi...@apache.org>.
lukaszlenart merged PR #610:
URL: https://github.com/apache/struts/pull/610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org