[GitHub] [hbase] virajjasani commented on a change in pull request #3366: HBASE-25985 ReplicationSourceWALReader#run - Reset sleepMultiplier in loop once out of any IOE

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #3366:
URL: https://github.com/apache/hbase/pull/3366#discussion_r648025218



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -151,6 +151,7 @@ public void run() {
             } else {
               addBatchToShippingQueue(batch);
             }
+            sleepMultiplier = 1;

Review comment:
       Good to keep this after `while (isReaderRunning()) {` perhaps?
   If we encounter InterruptedException while sleeping if peer is not enabled, we might skip this reset? But on the other hand, after getting interrupted, we are not dealing with this multiplier also. But if some other Exception is caught before reaching here, this reset won't apply.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org