You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nleclerc <gi...@git.apache.org> on 2015/10/01 18:10:37 UTC
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
GitHub user nleclerc opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48
Added support for video quality option on iOS platform.
Not much more to add.
Maybe that it's a bit of a shame that quality has just 2 levels but i'm just conforming to existing code here.
I spotted a [https://github.com/apache/cordova-plugin-media-capture/pull/32](pull request by kkabell) introducing a percentage based quality, maybe it would be a better idea.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/coqsenpate/cordova-plugin-media-capture video-quality-ios
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 163fa1a90fa391a2b9240fcb4651669befb5154c
Author: Nicolas Leclerc <ni...@coqsenpate.com>
Date: 2015-10-01T15:57:32Z
Added support for video quality option on iOS platform.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #48: Added support for video quality opti...
Posted by ryanwilliams83 <gi...@git.apache.org>.
Github user ryanwilliams83 commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/48
Couple of issues with this pull request.
1) It changes the behavior for existing implementations from Medium to Low
2) The commits include white space changes for unrelated parts of the files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
Posted by contra <gi...@git.apache.org>.
Github user contra commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48#issuecomment-147854627
Is there any reason the cordova project refuses to accept community contributions? Seriously, every project has about 20 open perfectly fine pull requests that just get ignored and the projects rot away. What's going on here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
Posted by brianleroux <gi...@git.apache.org>.
Github user brianleroux commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48#issuecomment-147861645
Also I'd totally vote for you in the mayoral race if I could vote here. :bomb: :boom:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
Posted by brianleroux <gi...@git.apache.org>.
Github user brianleroux commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48#issuecomment-147875815
yea ideally everything is a 3rd party plugin to cordova (imo) tho basic stuff like camera *should* be owned by apache it just isn't fast enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
Posted by brianleroux <gi...@git.apache.org>.
Github user brianleroux commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48#issuecomment-147861435
Speed in Apache process and not enough committers to keep up mostly @contra. Big push right now from committers on our team to focus on iOS9 (bugs in the platform not plugin features).
cc'ing @shazron && @stevengill to see if we can get this (and anything else you think is important into their queues)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: Added support for video...
Posted by contra <gi...@git.apache.org>.
Github user contra commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/48#issuecomment-147862617
@brianleroux I think as far as this project is concerned there's a lot of goofs on the API end that could be fixed pretty easily.
Mainly for me:
- Can't set the camera between back-facing or front-facing
- Can't change the quality on iOS, even though the platform supports this (there are 3 PRs open to fix this, seems like this is also a sticking point for other people)
- Can't customize any aspect of the recording interface
- Can't ask for a blob or base64 URI, which means the recording always has to hit the FS
- Takes about 5 seconds to load the first time, maybe this is just in non-release mode tough
There's also this project which forked off and did everything themselves https://github.com/EddyVerbruggen/VideoCapturePlus-PhoneGap-Plugin
Adds:
- quality
- overlay text on the recording screen
- ability to specify the camera
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org