[incubator-kyuubi] branch master updated: [KYUUBI #2951] No need to extend CompositeService for MetadataManager

[fe...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new c8f18f000 [KYUUBI #2951] No need to extend CompositeService for MetadataManager
c8f18f000 is described below

commit c8f18f0001358ab957108716ec1a4e6d435cfa11
Author: Tianlin Liao <ti...@ebay.com>
AuthorDate: Mon Jun 27 20:52:15 2022 +0800

    [KYUUBI #2951] No need to extend CompositeService for MetadataManager
    
    ### _Why are the changes needed?_
    
    CompositeService is not needed, use AbstractService.
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #2951 from lightning-L/fix.
    
    Closes #2951
    
    4d563344 [Tianlin Liao] no need to extend CompositeService for MetadataManager
    
    Authored-by: Tianlin Liao <ti...@ebay.com>
    Signed-off-by: Fei Wang <fw...@ebay.com>
---
 .../scala/org/apache/kyuubi/server/metadata/MetadataManager.scala     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
index 7e09ebf0a..17a586604 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
@@ -29,11 +29,11 @@ import org.apache.kyuubi.config.KyuubiConf.METADATA_MAX_AGE
 import org.apache.kyuubi.engine.ApplicationOperation._
 import org.apache.kyuubi.operation.OperationState
 import org.apache.kyuubi.server.metadata.api.{Metadata, MetadataFilter}
-import org.apache.kyuubi.service.CompositeService
+import org.apache.kyuubi.service.AbstractService
 import org.apache.kyuubi.session.SessionType
 import org.apache.kyuubi.util.{ClassUtils, ThreadUtils}
 
-class MetadataManager extends CompositeService("MetadataManager") {
+class MetadataManager extends AbstractService("MetadataManager") {
   import MetadataManager._
 
   private var _metadataStore: MetadataStore = _