You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Christo Lolov (Jira)" <ji...@apache.org> on 2022/09/06 10:06:00 UTC

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

     [ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christo Lolov updated KAFKA-14133:
----------------------------------
    Description: 
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here rely solely on EasyMock.{color}

Unless stated in brackets the tests are in the streams module.

A list of tests which still require to be moved from EasyMock to Mockito as of 2nd of August 2022 which do not have a Jira issue and do not have pull requests I am aware of which are opened:

{color:#ff8b00}In Review{color}
{color:#00875A}Merged{color}
 # -{color:#00875A}WorkerConnectorTest{color} (connect) (owner:- [~yash.mayya] -)-
 # -{color:#00875A}WorkerCoordinatorTest{color} (connect) (owner:- [~yash.mayya] -)-
 # -{color:#00875A}RootResourceTest{color} (connect) (owner:- [~yash.mayya] -)-
 # -{color:#00875A}ByteArrayProducerRecordEquals{color} (connect) (owner:- [~yash.mayya] -)-
 # {color:#ff8b00}KStreamFlatTransformTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamFlatTransformValuesTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamPrintTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamRepartitionTest{color} (owner: Christo)
 # {color:#ff8b00}MaterializedInternalTest{color} (owner: Christo)
 # {color:#ff8b00}TransformerSupplierAdapterTest{color} (owner: Christo)
 # {color:#ff8b00}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
 # {color:#ff8b00}ClientUtilsTest{color} (owner: Christo)
 # {color:#ff8b00}HighAvailabilityStreamsPartitionAssignorTest{color} (owner: Christo)
 # {color:#ff8b00}StreamsRebalanceListenerTest{color} (owner: Christo)
 # {color:#ff8b00}TimestampedKeyValueStoreMaterializerTest{color} (owner: Christo)
 # {color:#ff8b00}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingInMemorySessionStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingPersistentSessionStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingPersistentWindowStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingTimestampedKeyValueBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
 # {color:#ff8b00}KeyValueStoreBuilderTest{color} (owner: Christo)
 # {color:#ff8b00}RocksDBStoreTest{color} (owner: Christo)
 # {color:#ff8b00}StreamThreadStateStoreProviderTest{color} (owner: Christo)
 # {color:#ff8b00}TopologyTest{color} (owner: Christo)
 # {color:#ff8b00}KTableSuppressProcessorTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
 # InternalTopicManagerTest (owner: Christo)
 # ProcessorContextImplTest (owner: Christo)
 # WriteConsistencyVectorTest (owner: Christo)
 # StreamsAssignmentScaleTest (owner: Christo)
 # StreamsPartitionAssignorTest (owner: Christo)
 # TaskManagerTest (owner: Christo)
 # AssignmentTestUtils (owner: Christo)
 # ProcessorStateManagerTest ({*}WIP{*} owner: Matthew)
 # StandbyTaskTest ({*}WIP{*} owner: Matthew)
 # StoreChangelogReaderTest ({*}WIP{*} owner: Matthew)
 # StreamTaskTest ({*}WIP{*} owner: Matthew)
 # StreamThreadTest ({*}WIP{*} owner: Matthew)
 # StreamsMetricsImplTest
 # TimeOrderedCachingPersistentWindowStoreTest
 # TimeOrderedWindowStoreTest

*The coverage report for the above tests after the change should be >= to what the coverage is now.*

  was:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here rely solely on EasyMock.{color}

Unless stated in brackets the tests are in the streams module.

A list of tests which still require to be moved from EasyMock to Mockito as of 2nd of August 2022 which do not have a Jira issue and do not have pull requests I am aware of which are opened:

{color:#ff8b00}In Review{color}
 # -WorkerConnectorTest (connect) (owner:- [~yash.mayya] -)-
 # -WorkerCoordinatorTest (connect) (owner:- [~yash.mayya] -)-
 # -RootResourceTest (connect) (owner:- [~yash.mayya] -)-
 # -ByteArrayProducerRecordEquals (connect) (owner:- [~yash.mayya] -)-
 # {color:#ff8b00}KStreamFlatTransformTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamFlatTransformValuesTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamPrintTest{color} (owner: Christo)
 # {color:#ff8b00}KStreamRepartitionTest{color} (owner: Christo)
 # {color:#ff8b00}MaterializedInternalTest{color} (owner: Christo)
 # {color:#ff8b00}TransformerSupplierAdapterTest{color} (owner: Christo)
 # {color:#ff8b00}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
 # {color:#ff8b00}ClientUtilsTest{color} (owner: Christo)
 # {color:#ff8b00}HighAvailabilityStreamsPartitionAssignorTest{color} (owner: Christo)
 # {color:#ff8b00}StreamsRebalanceListenerTest{color} (owner: Christo)
 # {color:#ff8b00}TimestampedKeyValueStoreMaterializerTest{color} (owner: Christo)
 # {color:#ff8b00}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingInMemorySessionStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingPersistentSessionStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CachingPersistentWindowStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingTimestampedKeyValueBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
 # {color:#ff8b00}KeyValueStoreBuilderTest{color} (owner: Christo)
 # {color:#ff8b00}RocksDBStoreTest{color} (owner: Christo)
 # {color:#ff8b00}StreamThreadStateStoreProviderTest{color} (owner: Christo)
 # {color:#ff8b00}TopologyTest{color} (owner: Christo)
 # {color:#ff8b00}KTableSuppressProcessorTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
 # {color:#ff8b00}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
 # InternalTopicManagerTest (owner: Christo)
 # ProcessorContextImplTest (owner: Christo)
 # WriteConsistencyVectorTest (owner: Christo)
 # StreamsAssignmentScaleTest (owner: Christo)
 # StreamsPartitionAssignorTest (owner: Christo)
 # TaskManagerTest (owner: Christo)
 # AssignmentTestUtils (owner: Christo)
 # ProcessorStateManagerTest ({*}WIP{*} owner: Matthew)
 # StandbyTaskTest ({*}WIP{*} owner: Matthew)
 # StoreChangelogReaderTest ({*}WIP{*} owner: Matthew)
 # StreamTaskTest ({*}WIP{*} owner: Matthew)
 # StreamThreadTest ({*}WIP{*} owner: Matthew)
 # StreamsMetricsImplTest
 # TimeOrderedCachingPersistentWindowStoreTest
 # TimeOrderedWindowStoreTest

*The coverage report for the above tests after the change should be >= to what the coverage is now.*


> Remaining EasyMock to Mockito tests
> -----------------------------------
>
>                 Key: KAFKA-14133
>                 URL: https://issues.apache.org/jira/browse/KAFKA-14133
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Christo Lolov
>            Assignee: Christo Lolov
>            Priority: Major
>
> {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put those in https://issues.apache.org/jira/browse/KAFKA-14132. Tests here rely solely on EasyMock.{color}
> Unless stated in brackets the tests are in the streams module.
> A list of tests which still require to be moved from EasyMock to Mockito as of 2nd of August 2022 which do not have a Jira issue and do not have pull requests I am aware of which are opened:
> {color:#ff8b00}In Review{color}
> {color:#00875A}Merged{color}
>  # -{color:#00875A}WorkerConnectorTest{color} (connect) (owner:- [~yash.mayya] -)-
>  # -{color:#00875A}WorkerCoordinatorTest{color} (connect) (owner:- [~yash.mayya] -)-
>  # -{color:#00875A}RootResourceTest{color} (connect) (owner:- [~yash.mayya] -)-
>  # -{color:#00875A}ByteArrayProducerRecordEquals{color} (connect) (owner:- [~yash.mayya] -)-
>  # {color:#ff8b00}KStreamFlatTransformTest{color} (owner: Christo)
>  # {color:#ff8b00}KStreamFlatTransformValuesTest{color} (owner: Christo)
>  # {color:#ff8b00}KStreamPrintTest{color} (owner: Christo)
>  # {color:#ff8b00}KStreamRepartitionTest{color} (owner: Christo)
>  # {color:#ff8b00}MaterializedInternalTest{color} (owner: Christo)
>  # {color:#ff8b00}TransformerSupplierAdapterTest{color} (owner: Christo)
>  # {color:#ff8b00}KTableSuppressProcessorMetricsTest{color} (owner: Christo)
>  # {color:#ff8b00}ClientUtilsTest{color} (owner: Christo)
>  # {color:#ff8b00}HighAvailabilityStreamsPartitionAssignorTest{color} (owner: Christo)
>  # {color:#ff8b00}StreamsRebalanceListenerTest{color} (owner: Christo)
>  # {color:#ff8b00}TimestampedKeyValueStoreMaterializerTest{color} (owner: Christo)
>  # {color:#ff8b00}CachingInMemoryKeyValueStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}CachingInMemorySessionStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}CachingPersistentSessionStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}CachingPersistentWindowStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}ChangeLoggingKeyValueBytesStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}ChangeLoggingTimestampedKeyValueBytesStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}CompositeReadOnlyWindowStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}KeyValueStoreBuilderTest{color} (owner: Christo)
>  # {color:#ff8b00}RocksDBStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}StreamThreadStateStoreProviderTest{color} (owner: Christo)
>  # {color:#ff8b00}TopologyTest{color} (owner: Christo)
>  # {color:#ff8b00}KTableSuppressProcessorTest{color} (owner: Christo)
>  # {color:#ff8b00}ChangeLoggingSessionBytesStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}ChangeLoggingTimestampedWindowBytesStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}ChangeLoggingWindowBytesStoreTest{color} (owner: Christo)
>  # {color:#ff8b00}MeteredTimestampedWindowStoreTest{color} (owner: Christo)
>  # InternalTopicManagerTest (owner: Christo)
>  # ProcessorContextImplTest (owner: Christo)
>  # WriteConsistencyVectorTest (owner: Christo)
>  # StreamsAssignmentScaleTest (owner: Christo)
>  # StreamsPartitionAssignorTest (owner: Christo)
>  # TaskManagerTest (owner: Christo)
>  # AssignmentTestUtils (owner: Christo)
>  # ProcessorStateManagerTest ({*}WIP{*} owner: Matthew)
>  # StandbyTaskTest ({*}WIP{*} owner: Matthew)
>  # StoreChangelogReaderTest ({*}WIP{*} owner: Matthew)
>  # StreamTaskTest ({*}WIP{*} owner: Matthew)
>  # StreamThreadTest ({*}WIP{*} owner: Matthew)
>  # StreamsMetricsImplTest
>  # TimeOrderedCachingPersistentWindowStoreTest
>  # TimeOrderedWindowStoreTest
> *The coverage report for the above tests after the change should be >= to what the coverage is now.*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)