[GitHub] [iceberg] findepi commented on a diff in pull request #4741: Add table-level statistics support

[GitBox <gi...@apache.org>]

findepi commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r872153480


##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -147,21 +185,69 @@ static Snapshot fromJson(FileIO io, JsonNode node) {
 
     Integer schemaId = JsonUtil.getIntOrNull(SCHEMA_ID, node);
 
+    List<StatisticsFile> statistics = null;

Review Comment:
   @zinking i agree with you and what you suggest is how i write code myself. However, i think i am following project rules here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org