You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@streampipes.apache.org by "bossenti (via GitHub)" <gi...@apache.org> on 2023/03/22 21:23:18 UTC

[I] Extend Python docs with dark mode (streampipes)

bossenti opened a new issue, #1442:
URL: https://github.com/apache/streampipes/issues/1442

### Body

Our [Python docs](https://github.com/apache/streampipes/tree/dev/streampipes-client-python/docs) are built using [mkdocs-material](https://squidfunk.github.io/mkdocs-material/).
This allows to easily configure a dark mode as described here: https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/?h=dark+mode#color-palette-toggle
This issue is about configuring the dark mode for our Python docs via the [mkdocs.yml](https://github.com/apache/streampipes/blob/dev/streampipes-client-python/mkdocs.yml). Please pay some attention on the selected primary and accent color for the dark theme.

### Monitoring
As this issue is marked as good first issue: one of @SvenO3 , or @bossenti are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
This issue is ideal for people that are interested in getting started with StreamPipes, and want to get a little hands-on to our Python library.

### StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1483924523

   @bossenti is it legal to use this edited logo? like no license issue etc...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1482289188

   Thank you @tenthe for assigning this issue to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.

tenthe commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1482378430

   Yes, you are right it is quite unreadable. @bossenti is it possible to use the white logo for dark mode?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "bossenti (via GitHub)" <gi...@apache.org>.

bossenti commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1493423668

   completed with #1454 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1485744567

   @tenthe I have committed with the white logo, please accept the PR.
   > It looks like this now
   ![image](https://user-images.githubusercontent.com/55497045/228045988-5cf7afe7-6127-4a8a-9c8a-7538b3b3f79d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1483200225

   # So I edited the logo to improve the readability with dark mode.
   > Is it ok to use this logo?
   
   ## Light Mode -
   ![image](https://user-images.githubusercontent.com/55497045/227602679-e331bed8-853b-45ec-adbe-6953b94e5854.png)
   
   ## Dark Mode -
   ![image](https://user-images.githubusercontent.com/55497045/227603054-1a88d56a-90df-4485-ab22-33ad3e39945b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1480710750

   Hey, I want to work on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1485710933

   ok got it @tenthe 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1482352024

   What about the logo?
   > its getting a bit unreadable due to dark colors
   
   ![image](https://user-images.githubusercontent.com/55497045/227449704-2a505b2a-13f6-4a18-a4d0-9e9c9fad3104.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1484510026

   Ok sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "bossenti (via GitHub)" <gi...@apache.org>.

bossenti commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1483063705

   For images within markdown files there is a functionality to distinguish between dark and light mode:https://squidfunk.github.io/mkdocs-material/reference/images/#light-and-dark-mode
   However, I think this does not apply for the general logo (appearing in the top left corner)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.

tenthe commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1485187216

   I think it would be good if it looks the same for light and dark mode. 
   It should be enough if you take the green out of the current logo (streampipes-python-dark.png)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "dev-DTECH (via GitHub)" <gi...@apache.org>.

dev-DTECH commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1484527326

   @tenthe What about the python logo its not there in the all white logo.
   > Should I add it?
   ![image](https://user-images.githubusercontent.com/55497045/227850080-21fe3c4b-f7be-4521-9418-a77e84ee6f6c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "tenthe (via GitHub)" <gi...@apache.org>.

tenthe commented on issue #1442:
URL: https://github.com/apache/streampipes/issues/1442#issuecomment-1484507550

   Hello @dev-DTECH,
   thanks for the PR. 
   I would prefer to use the all white logo instead, like the one in the upper left corner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Extend Python docs with dark mode (streampipes)

Posted by "bossenti (via GitHub)" <gi...@apache.org>.

bossenti closed issue #1442: Extend Python docs with dark mode
URL: https://github.com/apache/streampipes/issues/1442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org