You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by tomasatdatabricks <gi...@git.apache.org> on 2018/01/09 02:11:44 UTC

[GitHub] spark pull request #20168: [SPARK-22730][ML] Add ImageSchema support for non...

Github user tomasatdatabricks commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20168#discussion_r160304870
  
    --- Diff: python/pyspark/ml/image.py ---
    @@ -201,8 +243,9 @@ def readImages(self, path, recursive=False, numPartitions=-1,
             .. versionadded:: 2.3.0
             """
     
    -        spark = SparkSession.builder.getOrCreate()
    -        image_schema = spark._jvm.org.apache.spark.ml.image.ImageSchema
    +        ctx = SparkContext.getOrCreate()
    --- End diff --
    
    Good catch. Looks like this was caused by auto-rebasing onto the latest changes. My original change was only to replace _active_context with getOrCreate() but it was clearly made obsolete in the meantime. I'll just remove it. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org