You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/03/31 08:00:08 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1292: MINIFICPP-1792 Fix build with cmake 3.23.0
lordgamez opened a new pull request #1292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1292
According to the CMake [GNUInstallDirs](https://cmake.org/cmake/help/v3.23/module/GNUInstallDirs.html) documentation `CMAKE_INSTALL_LIBDIR` can contain the multiarch-tuple on Debian besides the previously used `lib`/`lib64` values. On contrary to earlier versions this is now specific to the case when `CMAKE_INSTALL_PREFIX` is set to `/`, `/usr`, or `/usr/local`. As `/usr/local` is the default value, in our build this will be used setting the `CMAKE_INSTALL_LIBDIR` to for example `lib/x86_64-linux-gnu` which causes a contradiction with the library paths of the external projects built where `CMAKE_INSTALL_PREFIX` is passed for their install paths thus it will be set to either `lib` or `lib64`.
As this change caused problems in other projects as well, it will be reverted in the next cmake release (without reverting the documentation change), but reintroduced later in after a discussion according to these:
https://gitlab.kitware.com/cmake/cmake/-/issues/23365
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7127
This change should fix the current problem and avoid any problems later if the change is reintroduced. It should also fix similar problems listed in ARM compilations: https://issues.apache.org/jira/browse/MINIFICPP-1756
https://issues.apache.org/jira/browse/MINIFICPP-1792
----------------------------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1292: MINIFICPP-1792 Fix build with cmake 3.23.0
Posted by GitBox <gi...@apache.org>.
adamdebreceni closed pull request #1292:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org